Added code and tests to check for non-existing select items from list #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@adwu73 submitted a pull request, robotframework#92, with changes to perform this check but we had delayed pulling it and in the meantime other chnages were made. I am resubmitting similar changes working out the best way to catch and report the error.
Now check to see if select list is multi-selection or not. If it is multi- select then raise error for any non-existing item(s). If it is a single select list then log warning if any item, up to the second to last item, that does not exist within the select list. And if the last item does not exist then a ValueError is thrown. This discerning error/warning reporting for single select list was designed to accommodate current stated operation of the keyword, "If more than one value is given for a single-selection list, the last value will be selected."
Added information about exception for non-existing items. Also updated CHANGES.rst.
emanlove
added a commit
that referenced
this pull request
Sep 1, 2013
Added code and tests to check for non-existing select items from list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92.