Skip to content

Conversation

mayask
Copy link
Contributor

@mayask mayask commented Oct 7, 2013

I've almost fixed all failing tests, please take a look at the details below:

  1. Fixed Mouse Up keyword attempting to click_and_hold before release therefore emitting mousedown event;
  2. Fixed Unselect Non-Existing Item From List test post-processing LOG command failing with wrong keyword index;
  3. Refactored Mouse Down On Link test to be clearer;
  4. Updated Click Element At Coordinates test with more "expected" coordinates.

Also I would like you to take a look at Click Element At Coordinates test one more time. It seems to me that selenium doesn't perform move_to_element.move_by_offset.click action chain well. I've submitted the issue on google code. Actually it's the last issue remained, and it would be really cool to get it fixed soon.

@ghost ghost assigned emanlove Oct 16, 2013
@emanlove
Copy link
Member

@myaskevich: Thanks a lot for fixing these issues!

I wanted to say though that your changes to Click Element At Coordinates were in error but I see you're correct. There is an error in the implementation of that keyword and that was my error. In dealing with a Selenium/Firefox issue I was trying different methods of clicking the element. For some (very poor) reason I left it with the implementation of

... move_to_element(element).move_by_offset(xoffset, yoffset) ...

instead of

... move_to_element_with_offset(element, xoffset, yoffset) ...

thinking these two action chains were equivalent. They are not. The former moves to the center of the element (move_to_element) then offsets from the center. The latter offsets from the top left corner which was the intended action (See [1]).

Thanks @myaskevich for bringing my error to light and for fixing these issues. I will go ahead an merge these changes.

emanlove added a commit that referenced this pull request Oct 16, 2013
Fixed Mouse Up keyword attempting to click and hold one more time before release
@emanlove emanlove merged commit cf971d9 into robotframework:master Oct 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants