fix(babel): clone cached helper identifier before returning it (#584)

Andarist · web-flow · commit c5e5f58d30b3 · 2020-11-07T08:49:00.000-05:00
diff --git a/packages/babel/src/bundledHelpersPlugin.js b/packages/babel/src/bundledHelpersPlugin.js
@@ -2,7 +2,7 @@ import { addNamed } from '@babel/helper-module-imports';
 
 import { HELPERS } from './constants';
 
-export default function importHelperPlugin() {
+export default function importHelperPlugin({ types: t }) {
   return {
     pre(file) {
       const cachedHelpers = {};
@@ -12,7 +12,7 @@ export default function importHelperPlugin() {
         }
 
         if (cachedHelpers[name]) {
-          return cachedHelpers[name];
+          return t.cloneNode(cachedHelpers[name]);
         }
 
         return (cachedHelpers[name] = addNamed(file.path, name, HELPERS));

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@ import { addNamed } from '@babel/helper-module-imports';`
`2`	`2`
`3`	`3`	`import { HELPERS } from './constants';`
`4`	`4`
`5`		`-export default function importHelperPlugin() {`
	`5`	`+export default function importHelperPlugin({ types: t }) {`
`6`	`6`	`return {`
`7`	`7`	`pre(file) {`
`8`	`8`	`const cachedHelpers = {};`
`@@ -12,7 +12,7 @@ export default function importHelperPlugin() {`
`12`	`12`	`}`
`13`	`13`
`14`	`14`	`if (cachedHelpers[name]) {`
`15`		`- return cachedHelpers[name];`
	`15`	`+ return t.cloneNode(cachedHelpers[name]);`
`16`	`16`	`}`
`17`	`17`
`18`	`18`	`return (cachedHelpers[name] = addNamed(file.path, name, HELPERS));`