[PyROOT] Move CPython extensions into subdirectories

Closes #14917.

Author: guitargeek

bindings/jupyroot/CMakeLists.txt

@@ -34,6 +34,15 @@ set(libname JupyROOT)
 
 # libJupyROOT uses ROOT headers from source dirs and depends on Core
 add_library(${libname} SHARED src/IOHandler.cxx)
+
+# To make sure that the library also ends up in the right subdirectory in the
+# build directory tree.
+if(MSVC)
+  set_target_properties(${libname} PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin/JupyROOT)
+else()
+  set_target_properties(${libname} PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib/JupyROOT)
+endif()
+
 # Set the suffix to '.so' and the prefix to 'lib'
 set_target_properties(${libname} PROPERTIES  ${ROOT_LIBRARY_PROPERTIES})
 if(MSVC)
@@ -56,9 +65,9 @@ endforeach()
 
 # Install library
 install(TARGETS ${libname} EXPORT ${CMAKE_PROJECT_NAME}Exports
-                            RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT libraries
-                            LIBRARY DESTINATION ${CMAKE_INSTALL_PYTHONDIR} COMPONENT libraries
-                            ARCHIVE DESTINATION ${CMAKE_INSTALL_PYTHONDIR} COMPONENT libraries)
+                            RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}/JupyROOT COMPONENT libraries
+                            LIBRARY DESTINATION ${CMAKE_INSTALL_PYTHONDIR}/JupyROOT COMPONENT libraries
+                            ARCHIVE DESTINATION ${CMAKE_INSTALL_PYTHONDIR}/JupyROOT COMPONENT libraries)
 
 # Install Python sources and bytecode
 install(DIRECTORY ${localruntimedir}/JupyROOT

bindings/jupyroot/python/JupyROOT/helpers/handlers.py

@@ -19,7 +19,7 @@
 import queue
 
 from JupyROOT import helpers
-import libJupyROOT as _lib
+import JupyROOT.libJupyROOT as _lib
 
 
 class IOHandler(object):

bindings/pyroot/pythonizations/CMakeLists.txt

@@ -144,6 +144,14 @@ set(libname ROOTPythonizations)
 
 add_library(${libname} SHARED ${cpp_sources})
 
+# To make sure that the library also ends up in the right subdirectory in the
+# build directory tree.
+if(MSVC)
+  set_target_properties(${libname} PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/bin/ROOT)
+else()
+  set_target_properties(${libname} PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${CMAKE_BINARY_DIR}/lib/ROOT)
+endif()
+
 # Insert the ROOTPythonizationsPySources in the dependency graph
 add_dependencies(${libname} ROOTPythonizationsPySources)
 
@@ -187,16 +195,16 @@ target_link_libraries(PyROOT INTERFACE cppyy_backend cppyy ROOTPythonizations)
 
 # Install library
 install(TARGETS ${libname} EXPORT ${CMAKE_PROJECT_NAME}Exports
-                            RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT libraries
-                            LIBRARY DESTINATION ${CMAKE_INSTALL_PYTHONDIR} COMPONENT libraries
-                            ARCHIVE DESTINATION ${CMAKE_INSTALL_PYTHONDIR} COMPONENT libraries)
+                            RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}/ROOT COMPONENT libraries
+                            LIBRARY DESTINATION ${CMAKE_INSTALL_PYTHONDIR}/ROOT COMPONENT libraries
+                            ARCHIVE DESTINATION ${CMAKE_INSTALL_PYTHONDIR}/ROOT COMPONENT libraries)
 
 # Install meta-target PyROOT3 (INTERFACE library)
 # Install library
 install(TARGETS PyROOT EXPORT ${CMAKE_PROJECT_NAME}Exports
-                            RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} COMPONENT libraries
-                            LIBRARY DESTINATION ${CMAKE_INSTALL_PYTHONDIR} COMPONENT libraries
-                            ARCHIVE DESTINATION ${CMAKE_INSTALL_PYTHONDIR} COMPONENT libraries)
+                            RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR}/ROOT COMPONENT libraries
+                            LIBRARY DESTINATION ${CMAKE_INSTALL_PYTHONDIR}/ROOT COMPONENT libraries
+                            ARCHIVE DESTINATION ${CMAKE_INSTALL_PYTHONDIR}/ROOT COMPONENT libraries)
 
 # Install Python sources and bytecode
 install(DIRECTORY ${localruntimedir}/ROOT

bindings/pyroot/pythonizations/python/ROOT/__init__.py

@@ -24,7 +24,7 @@
 
 import cppyy
 import sys, importlib
-import libROOTPythonizations
+import ROOT.libROOTPythonizations
 
 # Build cache of commonly used python strings (the cache is python intern, so
 # all strings are shared python-wide, not just in PyROOT).
@@ -184,8 +184,8 @@ def cleanup():
         facade.__dict__["app"].keep_polling = False
         facade.__dict__["app"].process_root_events.join()
 
-    if "libROOTPythonizations" in sys.modules:
-        backend = sys.modules["libROOTPythonizations"]
+    if "ROOT.libROOTPythonizations" in sys.modules:
+        backend = sys.modules["ROOT.libROOTPythonizations"]
 
         # Make sure all the objects regulated by PyROOT are deleted and their
         # Python proxies are properly nonified.

bindings/pyroot/pythonizations/python/ROOT/_application.py

@@ -13,7 +13,7 @@
 
 from cppyy.gbl import gSystem, gInterpreter, gEnv
 
-from libROOTPythonizations import InitApplication, InstallGUIEventInputHook
+from ROOT.libROOTPythonizations import InitApplication, InstallGUIEventInputHook
 
 
 class PyROOTApplication(object):

bindings/pyroot/pythonizations/python/ROOT/_facade.py

@@ -7,7 +7,7 @@
 import libcppyy as cppyy_backend
 from cppyy import gbl as gbl_namespace
 from cppyy import cppdef, include
-from libROOTPythonizations import gROOT
+from ROOT.libROOTPythonizations import gROOT
 from cppyy.gbl import gSystem
 import cppyy.ll
 

bindings/pyroot/pythonizations/python/ROOT/_pythonization/_cppinstance.py

@@ -9,7 +9,7 @@
 ################################################################################
 
 import libcppyy
-from libROOTPythonizations import AddCPPInstancePickling
+from ROOT.libROOTPythonizations import AddCPPInstancePickling
 
 def pythonize_cppinstance():
     klass = libcppyy.CPPInstance

bindings/pyroot/pythonizations/python/ROOT/_pythonization/_generic.py

@@ -8,7 +8,7 @@
 # For the list of contributors see $ROOTSYS/README/CREDITS.                    #
 ################################################################################
 
-from libROOTPythonizations import AddPrettyPrintingPyz
+from ROOT.libROOTPythonizations import AddPrettyPrintingPyz
 
 def _add_getitem_checked(klass):
     # Parameters:

bindings/pyroot/pythonizations/python/ROOT/_pythonization/_tclass.py

@@ -9,7 +9,7 @@
 ################################################################################
 
 import cppyy
-from libROOTPythonizations import AddTClassDynamicCastPyz
+from ROOT.libROOTPythonizations import AddTClassDynamicCastPyz
 
 
 def pythonize_tclass():

bindings/pyroot/pythonizations/python/ROOT/_pythonization/_tmva/__init__.py

@@ -16,7 +16,7 @@
 
 from .. import pythonization
 
-from libROOTPythonizations import gROOT
+from ROOT.libROOTPythonizations import gROOT
 
 from ._factory import Factory
 from ._dataloader import DataLoader