Skip to content

Conversation

@oxalica
Copy link
Contributor

@oxalica oxalica commented Aug 8, 2023

Currently the receiver type is copied from AST instead re-formatting through HirDisplay. Macro generated functions seem to have no spaces and their signature help are rendered like fn foo(&'amutself) instead of fn foo(&'a mut self).

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2023
@Veykril
Copy link
Member

Veykril commented Aug 15, 2023

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Aug 15, 2023

📌 Commit de86444 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Aug 15, 2023

⌛ Testing commit de86444 with merge 0fa822d...

@bors
Copy link
Contributor

bors commented Aug 15, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 0fa822d to master...

@bors bors merged commit 0fa822d into rust-lang:master Aug 15, 2023
@oxalica oxalica deleted the fix/sig-from-macro branch August 15, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants