Skip to content

feat: Add diagnostic with fix to replace trailing return <val>; with <val> #16460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 8, 2024
Merged

feat: Add diagnostic with fix to replace trailing return <val>; with <val> #16460

merged 5 commits into from
Feb 8, 2024

Conversation

@davidsemakula
Copy link
Contributor

@davidsemakula davidsemakula commented Jan 31, 2024

Works for functions and closures.
Ignores desugared return expressions (e.g. from desugared try operators).

Fixes: #10970
Completes: #11020

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 31, 2024
@davidsemakula davidsemakula changed the title feat: Add diagnostic with fix to replace trailing return <val>; with just <val> feat: Add diagnostic with fix to replace trailing return <val>; with<val> Jan 31, 2024
@davidsemakula davidsemakula changed the title feat: Add diagnostic with fix to replace trailing return <val>; with<val> feat: Add diagnostic with fix to replace trailing return <val>; with <val> Jan 31, 2024
Veykril
Veykril reviewed Jan 31, 2024
View reviewed changes
@davidsemakula davidsemakula force-pushed the trailing-return-diagnostic branch from 7cc6b86 to 8c63a32 Compare January 31, 2024 12:11
@davidsemakula davidsemakula requested a review from Veykril January 31, 2024 12:31
@Veykril
Copy link
Member

Veykril commented Feb 8, 2024

Thanks, needs a rebase!
@bors delegate+

@bors
Copy link
Contributor

bors commented Feb 8, 2024

✌️ @davidsemakula, you can now approve this pull request!

If @Veykril told you to "r=me" after making some further change, please make that change, then do @bors r=@Veykril

@davidsemakula davidsemakula force-pushed the trailing-return-diagnostic branch from 8c63a32 to 602acfc Compare February 8, 2024 16:37
@davidsemakula
Copy link
Contributor Author

davidsemakula commented Feb 8, 2024

@bors r=@Veykril

@bors
Copy link
Contributor

bors commented Feb 8, 2024

📌 Commit 602acfc has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 8, 2024

⌛ Testing commit 602acfc with merge e418c90...

@bors
Copy link
Contributor

bors commented Feb 8, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing e418c90 to master...

@bors bors merged commit e418c90 into rust-lang:master Feb 8, 2024
@davidsemakula davidsemakula deleted the trailing-return-diagnostic branch February 8, 2024 17:08
@aminya aminya mentioned this pull request Feb 12, 2024
Closed
This was referenced May 9, 2024
Closed
Closed
Closed
Closed
Merged
This was referenced May 28, 2024
Merged
Closed
Closed
This was referenced Jun 2, 2024
Closed
Merged
Merged
This was referenced Jun 11, 2024
Merged
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 18, 2024
Merged
@philips-software-forest-releaser philips-software-forest-releaser bot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Veykril Veykril Veykril approved these changes

Assignees

No one assigned

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: Diagnostic to replace trailing return <val>; with just <val>

4 participants

@davidsemakula @Veykril @bors @rustbot