Skip to content

Conversation

@roife
Copy link
Member

@roife roife commented Jun 6, 2024

fix #12728.

Changes

  • Use | as the separator for actions. (I'm not sure why we use ___ previously)
  • Reorder actions to match codelens

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 6, 2024
@roife
Copy link
Member Author

roife commented Jun 6, 2024

Before

image

After

image

@roife
Copy link
Member Author

roife commented Jun 6, 2024

It's weird that we haven't fixed it🫨. I used to think it was a bug of VSCode. 🙈

Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the idea was to have that as \n___\n which will render a line in markdown, though this works as well I think

@Veykril
Copy link
Member

Veykril commented Jun 6, 2024

@bors r+

@bors
Copy link
Contributor

bors commented Jun 6, 2024

📌 Commit 4a4b13c has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 6, 2024

⌛ Testing commit 4a4b13c with merge 5f3de78...

@roife
Copy link
Member Author

roife commented Jun 6, 2024

I think the idea was to have that as \n___\n which will render a line in markdown, though this works as well I think

That makes sense.

@bors
Copy link
Contributor

bors commented Jun 6, 2024

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 5f3de78 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect formatting of hover action

4 participants