Skip to content

Conversation

@Veykril
Copy link
Member

@Veykril Veykril commented Oct 23, 2024

cc #18387

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 23, 2024
Copy link
Contributor

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Lukas said here:

Basically under the assumption that the LRU stuff is causing the problem, here we compute the parse tree, then we compute the ast_id_map (which calls the parse tree query as well). Looking at the panic message, it looks like the ast_id_map is old, where as the tree is new (has one more character in it), so my gut feeling is that the ast_id_map is actually not being invalidated here, which might be because we repopulate the evicted parse tree cache entry prior to it (and not marking thigns as dirty where we should), but in the same query stack state

@Veykril Veykril enabled auto-merge October 23, 2024 20:23
@Veykril Veykril added this pull request to the merge queue Oct 23, 2024
Merged via the queue into rust-lang:master with commit 40492e1 Oct 23, 2024
9 checks passed
@Veykril Veykril deleted the veykril/push-wktpkuklnzot branch October 23, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants