Skip to content

Commit f19b8cb

Browse files
committed
chore: dont check cargo-util semver until 1.86 is released
This fixes the current confusing failures in our CI pipeline: * https://github.com/rust-lang/cargo/actions/runs/13465687015/job/37630870984 * https://github.com/rust-lang/cargo/actions/runs/13469881475/job/37642079118 CI job failed because of this major SemVer breakage: ```diff -pub fn strip_prefix_canonical<P: AsRef<Path>>( - path: P, - base: P, +pub fn strip_prefix_canonical( + path: impl AsRef<Path>, + base: impl AsRef<Path>, ) -> Result<PathBuf, std::path::StripPrefixError> { ``` While cargo-util does have that change violating SemVer, it is unlikely people use it with turbo-fish syntax. And cargo-util is essentially for internal use. See: * https://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/check-version-bump.20failure * https://forge.rust-lang.org/policies/crate-ownership.html#internal-use
1 parent 1d1d646 commit f19b8cb

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

crates/xtask-bump-check/src/xtask.rs

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,16 @@ fn bump_check(args: &clap::ArgMatches, gctx: &cargo::util::GlobalContext) -> Car
132132
// as the publish of these crates are not tied with Rust release process.
133133
// See `TO_PUBLISH` in publish.py.
134134
"home",
135+
// Don't check this util 1.86 is released.
136+
// While it does have a SemVer breakage,
137+
// it is unlikely people use it with turbo-fish syntax.
138+
// And cargo-util is essentially for internal use.
139+
//
140+
// See:
141+
//
142+
// * https://rust-lang.zulipchat.com/#narrow/channel/246057-t-cargo/topic/check-version-bump.20failure
143+
// * https://forge.rust-lang.org/policies/crate-ownership.html#internal-use
144+
"cargo-util",
135145
];
136146

137147
status(&format!("base commit `{}`", base_commit.id()))?;

0 commit comments

Comments
 (0)