diff --git a/src/cargo/core/compiler/custom_build.rs b/src/cargo/core/compiler/custom_build.rs index 8fa6cb8b1da..87c14e40bf0 100644 --- a/src/cargo/core/compiler/custom_build.rs +++ b/src/cargo/core/compiler/custom_build.rs @@ -299,7 +299,7 @@ fn build_work(cx: &mut Context<'_, '_>, unit: &Unit) -> CargoResult { let extra_link_arg = cx.bcx.config.cli_unstable().extra_link_arg; let nightly_features_allowed = cx.bcx.config.nightly_features_allowed; - let targets: Vec = unit.pkg.targets().iter().cloned().collect(); + let targets: Vec = unit.pkg.targets().to_vec(); // Need a separate copy for the fresh closure. let targets_fresh = targets.clone(); diff --git a/src/cargo/core/compiler/fingerprint.rs b/src/cargo/core/compiler/fingerprint.rs index d7636bf1823..7adb895c381 100644 --- a/src/cargo/core/compiler/fingerprint.rs +++ b/src/cargo/core/compiler/fingerprint.rs @@ -1320,12 +1320,7 @@ fn calculate_normal(cx: &mut Context<'_, '_>, unit: &Unit) -> CargoResult DrainState<'cfg> { .bcx .unit_graph .keys() - .filter(|unit| unit.pkg.name() == "diesel" && !unit.features.is_empty()) - .next() + .find(|unit| unit.pkg.name() == "diesel" && !unit.features.is_empty()) { Some(u) => u, // Unlikely due to features. diff --git a/src/cargo/core/compiler/timings.rs b/src/cargo/core/compiler/timings.rs index 836acac5cdb..4ca85c482c7 100644 --- a/src/cargo/core/compiler/timings.rs +++ b/src/cargo/core/compiler/timings.rs @@ -529,7 +529,7 @@ impl<'cfg> Timings<'cfg> { target: ut.target.clone(), start: round(ut.start), duration: round(ut.duration), - rmeta_time: ut.rmeta_time.map(|t| round(t)), + rmeta_time: ut.rmeta_time.map(round), unlocked_units, unlocked_rmeta_units, } diff --git a/src/cargo/ops/cargo_compile.rs b/src/cargo/ops/cargo_compile.rs index cfc117ee0b2..d37f304644c 100644 --- a/src/cargo/ops/cargo_compile.rs +++ b/src/cargo/ops/cargo_compile.rs @@ -568,7 +568,7 @@ pub fn create_bcx<'a, 'cfg>( // the target is a binary. Binary crates get their private items // documented by default. if rustdoc_document_private_items || unit.target.is_bin() { - let mut args = extra_args.take().unwrap_or_else(|| vec![]); + let mut args = extra_args.take().unwrap_or_default(); args.push("--document-private-items".into()); extra_args = Some(args); }