Skip to content

Commit 915169b

Browse files
committed
Simplify internal Allocator trait
1 parent e23fbfc commit 915169b

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

src/raw/alloc.rs

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,18 +20,16 @@ mod inner {
2020
use crate::alloc::alloc::{alloc, dealloc, Layout};
2121
use core::ptr::NonNull;
2222

23-
pub struct AllocError;
24-
2523
pub unsafe trait Allocator {
26-
fn allocate(&self, layout: Layout) -> Result<NonNull<u8>, AllocError>;
24+
fn allocate(&self, layout: Layout) -> Result<NonNull<u8>, ()>;
2725
unsafe fn deallocate(&self, ptr: NonNull<u8>, layout: Layout);
2826
}
2927

3028
#[derive(Copy, Clone)]
3129
pub struct Global;
3230
unsafe impl Allocator for Global {
33-
fn allocate(&self, layout: Layout) -> Result<NonNull<u8>, AllocError> {
34-
unsafe { NonNull::new(alloc(layout)).ok_or(AllocError) }
31+
fn allocate(&self, layout: Layout) -> Result<NonNull<u8>, ()> {
32+
unsafe { NonNull::new(alloc(layout)).ok_or(()) }
3533
}
3634
unsafe fn deallocate(&self, ptr: NonNull<u8>, layout: Layout) {
3735
dealloc(ptr.as_ptr(), layout)
@@ -45,21 +43,21 @@ mod inner {
4543

4644
#[allow(clippy::map_err_ignore)]
4745
pub fn do_alloc<A: Allocator>(alloc: &A, layout: Layout) -> Result<NonNull<u8>, ()> {
48-
alloc.allocate(layout).map_err(|_| ())
46+
alloc.allocate(layout)
4947
}
5048

5149
#[cfg(feature = "bumpalo")]
5250
unsafe impl Allocator for bumpalo::Bump {
53-
fn allocate(&self, layout: Layout) -> Result<NonNull<u8>, AllocError> {
54-
self.try_alloc_layout(layout).map_err(|_| AllocError)
51+
fn allocate(&self, layout: Layout) -> Result<NonNull<u8>, ()> {
52+
self.try_alloc_layout(layout).map_err(|_| ())
5553
}
5654
unsafe fn deallocate(&self, _ptr: NonNull<u8>, _layout: Layout) {}
5755
}
5856

5957
#[cfg(feature = "bumpalo")]
6058
unsafe impl Allocator for &'_ bumpalo::Bump {
61-
fn allocate(&self, layout: Layout) -> Result<NonNull<u8>, AllocError> {
62-
self.try_alloc_layout(layout).map_err(|_| AllocError)
59+
fn allocate(&self, layout: Layout) -> Result<NonNull<u8>, ()> {
60+
self.try_alloc_layout(layout).map_err(|_| ())
6361
}
6462
unsafe fn deallocate(&self, _ptr: NonNull<u8>, _layout: Layout) {}
6563
}

0 commit comments

Comments
 (0)