Change the range syntax that is giving ctest problems
#4311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tgross35: no appropriate reviewer found, use |
|
Also removing the i586 MSVC target rust-lang/rust#137957 |
`ctest` is iffy about whether or not it accepts `..=` syntax, and I can't figure out what makes it decide whether or not to accept it and sometimes random changes seem to make things fail, so just replace the syntax. This is simpler anyway, and closer matches the upstream definition [1]. Link: https://github.com/torvalds/linux/blob/80e54e84911a923c40d7bee33a34c1b4be148d7a/Makefile#L1316 [1]
Since [1], this target no longer exists so we need to remove it from CI. [1]: rust-lang/rust#137957
tgross35
force-pushed
the
ctest-syntax-fix
branch
from
41cd816 to
33c320a
Compare
tgross35
added
the
stable-nominated
3 tasks
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Mar 10, 2025
`ctest` is iffy about whether or not it accepts `..=` syntax, and I can't figure out what makes it decide whether or not to accept it and sometimes random changes seem to make things fail, so just replace the syntax. This is simpler anyway, and closer matches the upstream definition [1]. Link: https://github.com/torvalds/linux/blob/80e54e84911a923c40d7bee33a34c1b4be148d7a/Makefile#L1316 [1] (backport <rust-lang#4311>) (cherry picked from commit 1779f14)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Mar 10, 2025
Since [1], this target no longer exists so we need to remove it from CI. [1]: rust-lang/rust#137957 (backport <rust-lang#4311>) (cherry picked from commit 33c320a)
Merged
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Mar 10, 2025
`ctest` is iffy about whether or not it accepts `..=` syntax, and I can't figure out what makes it decide whether or not to accept it and sometimes random changes seem to make things fail, so just replace the syntax. This is simpler anyway, and closer matches the upstream definition [1]. Link: https://github.com/torvalds/linux/blob/80e54e84911a923c40d7bee33a34c1b4be148d7a/Makefile#L1316 [1] (backport <rust-lang#4311>) (cherry picked from commit 1779f14)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Mar 10, 2025
Since [1], this target no longer exists so we need to remove it from CI. [1]: rust-lang/rust#137957 (backport <rust-lang#4311>) (cherry picked from commit 33c320a)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Mar 10, 2025
`ctest` is iffy about whether or not it accepts `..=` syntax, and I can't figure out what makes it decide whether or not to accept it and sometimes random changes seem to make things fail, so just replace the syntax. This is simpler anyway, and closer matches the upstream definition [1]. Link: https://github.com/torvalds/linux/blob/80e54e84911a923c40d7bee33a34c1b4be148d7a/Makefile#L1316 [1] (backport <rust-lang#4311>) (cherry picked from commit 1779f14)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Mar 10, 2025
Since [1], this target no longer exists so we need to remove it from CI. [1]: rust-lang/rust#137957 (backport <rust-lang#4311>) (cherry picked from commit 33c320a)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Mar 10, 2025
`ctest` is iffy about whether or not it accepts `..=` syntax, and I can't figure out what makes it decide whether or not to accept it and sometimes random changes seem to make things fail, so just replace the syntax. This is simpler anyway, and closer matches the upstream definition [1]. Link: https://github.com/torvalds/linux/blob/80e54e84911a923c40d7bee33a34c1b4be148d7a/Makefile#L1316 [1] (backport <rust-lang#4311>) (cherry picked from commit 1779f14)
tgross35
added a commit
to tgross35/rust-libc
that referenced
this pull request
Mar 10, 2025
Since [1], this target no longer exists so we need to remove it from CI. [1]: rust-lang/rust#137957 (backport <rust-lang#4311>) (cherry picked from commit 33c320a)
tgross35
added
stable-applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctestis iffy about whether or not it accepts..=syntax, and I can't figure out what makes it decide whether or not to accept it and sometimes random changes seem to make things fail, so just replace the syntax.This is simpler anyway, and closer matches the upstream definition [1].
Link: https://github.com/torvalds/linux/blob/80e54e84911a923c40d7bee33a34c1b4be148d7a/Makefile#L1316 [1]