fix dogfood test

Author: tesuji

clippy_lints/src/let_arr_const.rs

@@ -90,10 +90,9 @@ impl<'tcx> LateLintPass<'tcx> for LetArrConst {
             if let ExprKind::Array(items @ [ref expr, ..]) = init.kind
                 && let ty = cx.typeck_results().expr_ty(expr)
                 && implements_trait(cx, ty, copy_id, &[])
+                && items.iter().all(|expr| is_const_evaluatable(cx, expr))
             {
-                if items.iter().all(|expr| is_const_evaluatable(cx, expr)) {
-                    should = true;
-                }
+                should = true;
             }
 
             if should {

clippy_lints/src/methods/option_as_ref_deref.rs

@@ -20,6 +20,16 @@ pub(super) fn check(
     is_mut: bool,
     msrv: &Msrv,
 ) {
+    static DEREF_ALIASES: [&[&str]; 7] = [
+        &paths::CSTRING_AS_C_STR,
+        &paths::OS_STRING_AS_OS_STR,
+        &paths::PATH_BUF_AS_PATH,
+        &paths::STRING_AS_STR,
+        &paths::STRING_AS_MUT_STR,
+        &paths::VEC_AS_SLICE,
+        &paths::VEC_AS_MUT_SLICE,
+    ];
+
     if !msrv.meets(msrvs::OPTION_AS_DEREF) {
         return;
     }
@@ -31,24 +41,14 @@ pub(super) fn check(
         return;
     }
 
-    let deref_aliases: [&[&str]; 7] = [
-        &paths::CSTRING_AS_C_STR,
-        &paths::OS_STRING_AS_OS_STR,
-        &paths::PATH_BUF_AS_PATH,
-        &paths::STRING_AS_STR,
-        &paths::STRING_AS_MUT_STR,
-        &paths::VEC_AS_SLICE,
-        &paths::VEC_AS_MUT_SLICE,
-    ];
-
     let is_deref = match map_arg.kind {
         hir::ExprKind::Path(ref expr_qpath) => {
             cx.qpath_res(expr_qpath, map_arg.hir_id)
                 .opt_def_id()
                 .map_or(false, |fun_def_id| {
                     cx.tcx.is_diagnostic_item(sym::deref_method, fun_def_id)
                         || cx.tcx.is_diagnostic_item(sym::deref_mut_method, fun_def_id)
-                        || deref_aliases.iter().any(|path| match_def_path(cx, fun_def_id, path))
+                        || DEREF_ALIASES.iter().any(|path| match_def_path(cx, fun_def_id, path))
                 })
         },
         hir::ExprKind::Closure(&hir::Closure { body, .. }) => {
@@ -69,7 +69,7 @@ pub(super) fn check(
                         let method_did = cx.typeck_results().type_dependent_def_id(closure_expr.hir_id).unwrap();
                         cx.tcx.is_diagnostic_item(sym::deref_method, method_did)
                             || cx.tcx.is_diagnostic_item(sym::deref_mut_method, method_did)
-                            || deref_aliases.iter().any(|path| match_def_path(cx, method_did, path))
+                            || DEREF_ALIASES.iter().any(|path| match_def_path(cx, method_did, path))
                     } else {
                         false
                     }

lintcheck/src/main.rs

@@ -855,7 +855,7 @@ fn clippy_project_root() -> &'static Path {
 
 #[test]
 fn lintcheck_test() {
-    let args = [
+    let args = *&[
         "run",
         "--target-dir",
         "lintcheck/target",

tests/ui-toml/disallowed_names_append/disallowed_names.rs

@@ -1,4 +1,5 @@
-#[warn(clippy::disallowed_names)]
+#![warn(clippy::disallowed_names)]
+#![allow(clippy::let_arr_const)]
 
 fn main() {
     // `foo` is part of the default configuration

tests/ui-toml/disallowed_names_append/disallowed_names.stderr

@@ -1,5 +1,5 @@
 error: use of a disallowed/placeholder name `foo`
-  --> tests/ui-toml/disallowed_names_append/disallowed_names.rs:5:9
+  --> tests/ui-toml/disallowed_names_append/disallowed_names.rs:6:9
    |
 LL |     let foo = "bar";
    |         ^^^
@@ -8,7 +8,7 @@ LL |     let foo = "bar";
    = help: to override `-D warnings` add `#[allow(clippy::disallowed_names)]`
 
 error: use of a disallowed/placeholder name `ducks`
-  --> tests/ui-toml/disallowed_names_append/disallowed_names.rs:7:9
+  --> tests/ui-toml/disallowed_names_append/disallowed_names.rs:8:9
    |
 LL |     let ducks = ["quack", "quack"];
    |         ^^^^^

tests/ui-toml/disallowed_names_replace/disallowed_names.rs

@@ -1,4 +1,5 @@
-#[warn(clippy::disallowed_names)]
+#![warn(clippy::disallowed_names)]
+#![allow(clippy::let_arr_const)]
 
 fn main() {
     // `foo` is part of the default configuration

tests/ui-toml/disallowed_names_replace/disallowed_names.stderr

@@ -1,5 +1,5 @@
 error: use of a disallowed/placeholder name `ducks`
-  --> tests/ui-toml/disallowed_names_replace/disallowed_names.rs:7:9
+  --> tests/ui-toml/disallowed_names_replace/disallowed_names.rs:8:9
    |
 LL |     let ducks = ["quack", "quack"];
    |         ^^^^^

tests/ui-toml/large_futures/large_futures.fixed

@@ -1,4 +1,5 @@
 #![warn(clippy::large_futures)]
+#![allow(clippy::let_arr_const)]
 
 fn main() {}
 

tests/ui-toml/large_futures/large_futures.rs

@@ -1,4 +1,5 @@
 #![warn(clippy::large_futures)]
+#![allow(clippy::let_arr_const)]
 
 fn main() {}
 

tests/ui-toml/large_futures/large_futures.stderr

@@ -1,5 +1,5 @@
 error: large future with a size of 1026 bytes
-  --> tests/ui-toml/large_futures/large_futures.rs:18:5
+  --> tests/ui-toml/large_futures/large_futures.rs:19:5
    |
 LL |     should_warn().await;
    |     ^^^^^^^^^^^^^ help: consider `Box::pin` on it: `Box::pin(should_warn())`