lint bootstrap, compiletest and tidy by default

Signed-off-by: onur-ozkan <[email protected]>

Author: onur-ozkan

src/bootstrap/src/core/build_steps/clippy.rs

@@ -185,8 +185,17 @@ impl Step for Rustc {
         let compiler = builder.compiler(builder.top_stage, builder.config.build);
         let target = self.target;
 
-        builder.ensure(compile::Std::new(compiler, compiler.host));
-        builder.ensure(compile::Std::new(compiler, target));
+        if compiler.stage != 0 {
+            // If we're not in stage 0, then we won't have a std from the beta
+            // compiler around. That means we need to make sure there's one in
+            // the sysroot for the compiler to find. Otherwise, we're going to
+            // fail when building crates that need to generate code (e.g., build
+            // scripts and their dependencies).
+            builder.ensure(compile::Std::new(compiler, compiler.host));
+            builder.ensure(compile::Std::new(compiler, target));
+        } else {
+            builder.ensure(check::Std::new(target));
+        }
 
         let mut cargo = builder::Cargo::new(
             builder,
@@ -224,9 +233,7 @@ impl Step for Rustc {
 macro_rules! lint_any {
     ($(
         $name:ident, $path:expr, $readable_name:expr
-        $(,is_external_tool = $external:expr)*
-        $(,is_unstable_tool = $unstable:expr)*
-        $(,allow_features = $allow_features:expr)?
+        $(,lint_by_default = $lint_by_default:expr)*
         ;
     )+) => {
         $(
@@ -238,6 +245,7 @@ macro_rules! lint_any {
 
         impl Step for $name {
             type Output = ();
+            const DEFAULT: bool = if false $(|| $lint_by_default)* { true } else { false };
 
             fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
                 run.path($path)
@@ -275,11 +283,15 @@ macro_rules! lint_any {
                     &target,
                 );
 
+                let stamp = builder
+                    .cargo_out(compiler, Mode::ToolRustc, target)
+                    .join(format!(".{}-check.stamp", stringify!($name).to_lowercase()));
+
                 run_cargo(
                     builder,
                     cargo,
                     lint_args(builder, &[]),
-                    &libstd_stamp(builder, compiler, target),
+                    &stamp,
                     vec![],
                     true,
                     false,
@@ -291,11 +303,11 @@ macro_rules! lint_any {
 }
 
 lint_any!(
-    Bootstrap, "src/bootstrap", "bootstrap";
-    BuildHelper, "src/tools/build_helper", "build_helper";
+    Bootstrap, "src/bootstrap", "bootstrap", lint_by_default = true;
+    BuildHelper, "src/tools/build_helper", "build_helper", lint_by_default = true;
     CoverageDump, "src/tools/coverage-dump", "coverage-dump";
-    Tidy, "src/tools/tidy", "tidy";
-    Compiletest, "src/tools/compiletest", "compiletest";
+    Tidy, "src/tools/tidy", "tidy", lint_by_default = true;
+    Compiletest, "src/tools/compiletest", "compiletest", lint_by_default = true;
     RemoteTestServer, "src/tools/remote-test-server", "remote-test-server";
     RemoteTestClient, "src/tools/remote-test-client", "remote-test-client";
 );

src/bootstrap/src/core/build_steps/compile.rs

@@ -2015,7 +2015,7 @@ pub fn run_cargo(
         crate::exit!(1);
     }
 
-    if builder.config.dry_run() || builder.kind == Kind::Clippy {
+    if builder.config.dry_run() {
         return Vec::new();
     }