Skip to content

Recognise new IPv6 documentation range from IETF RFC 9637 #135741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2025
Merged

Recognise new IPv6 documentation range from IETF RFC 9637 #135741

merged 1 commit into from
Jan 20, 2025

Conversation

@bardiharborow
Copy link
Contributor

@bardiharborow bardiharborow commented Jan 19, 2025 •
edited
Loading

This PR adds the 3fff::/20 range defined by IETF RFC 9637 to those ranges which Ipv6Addr::is_documentation recognises as a documentation IP.

See also: https://www.iana.org/assignments/iana-ipv6-special-registry/iana-ipv6-special-registry.xhtml
Unstable tracking issue: #27709

@rustbot
Copy link
Collaborator

rustbot commented Jan 19, 2025

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jan 19, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bardiharborow
Recognise new IPv6 documentation range from RFC9637
1f0e35e 
This commit adds the 3fff::/20 range defined by RFC9637 to those ranges which Ipv6Addr::is_documentation recognises as a documentation IP.
@bardiharborow bardiharborow changed the title Recognise new IPv6 documentation range from RFC9637 Recognise new IPv6 documentation range from IETF RFC 9637 Jan 20, 2025
@bardiharborow
Copy link
Contributor Author

bardiharborow commented Jan 20, 2025

@rustbot label A-io

@rustbot rustbot added the A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` label Jan 20, 2025
@Amanieu
Copy link
Member

Amanieu commented Jan 20, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 20, 2025

📌 Commit 1f0e35e has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 20, 2025
This was referenced Jan 20, 2025
Closed
Merged
@bors bors merged commit 8a7db69 into rust-lang:master Jan 20, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Jan 20, 2025
@bardiharborow bardiharborow deleted the std/net/rfc9637 branch January 21, 2025 14:52
@fgsch fgsch mentioned this pull request Jun 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Amanieu Amanieu

Labels

A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.86.0

Development

Successfully merging this pull request may close these issues.

5 participants

@bardiharborow @rustbot @rust-log-analyzer @Amanieu @bors