Skip to content

Fix ICE in pattern matching with generic const array length errors #147724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2025
Merged

Fix ICE in pattern matching with generic const array length errors #147724

merged 1 commit into from
Oct 19, 2025
+37 −9

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Oct 15, 2025 •
edited by rustbot
Loading

Fixes #139815

@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2025

Some changes occurred in match lowering

cc @Nadrieril

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 15, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2025

r? @jdonszelmann

rustbot has assigned @jdonszelmann.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang chenyukang force-pushed the yukang-fix-139815-ice branch from b5dac2d to e22d142 Compare October 15, 2025 23:59
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jdonszelmann
Copy link
Contributor

@chenyukang could you fix CI? Also, maybe consider #![allow(incomplete_features)]

@jdonszelmann
Copy link
Contributor

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 16, 2025
@chenyukang chenyukang force-pushed the yukang-fix-139815-ice branch from e22d142 to 4a886ad Compare October 16, 2025 11:16
@chenyukang
Copy link
Member Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 16, 2025
@jdonszelmann
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 18, 2025

📌 Commit 4a886ad has been approved by jdonszelmann

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 18, 2025
@jdonszelmann
Copy link
Contributor

@bors rollup

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 18, 2025
@matthiaskrgr
Rollup merge of rust-lang#147724 - chenyukang:yukang-fix-139815-ice, …
92152f3 
…r=jdonszelmann

Fix ICE in pattern matching with generic const array length errors

Fixes rust-lang#139815
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 18, 2025
Closed
bors added a commit that referenced this pull request Oct 18, 2025
@bors
Auto merge of #147856 - matthiaskrgr:rollup-ksxc78w, r=matthiaskrgr
ec669eb 
Rollup of 8 pull requests

Successful merges:

 - #138679 (Issue-125323: ICE non-ADT in struct pattern when long time constant evaluation is in for loop)
 - #146167 (Deny-by-default never type lints)
 - #146490 (Rehome 26 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#5 of Batch #2])
 - #147438 (Rename "non-inline module" to "file module" in proc macro diagnostics)
 - #147724 (Fix ICE in pattern matching with generic const array length errors)
 - #147813 (Warn on unused_attributes in uitests )
 - #147816 (Do not error out for `download-rustc` if LTO is configured)
 - #147845 (Add regression test for 134355)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 18, 2025
@matthiaskrgr
Rollup merge of rust-lang#147724 - chenyukang:yukang-fix-139815-ice, …
c0e7ccc 
…r=jdonszelmann

Fix ICE in pattern matching with generic const array length errors

Fixes rust-lang#139815
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 18, 2025
Merged
bors added a commit that referenced this pull request Oct 19, 2025
@bors
Auto merge of #147863 - matthiaskrgr:rollup-l4alyf0, r=matthiaskrgr
377a931 
Rollup of 7 pull requests

Successful merges:

 - #138679 (Issue-125323: ICE non-ADT in struct pattern when long time constant evaluation is in for loop)
 - #146490 (Rehome 26 `tests/ui/issues/` tests to other subdirectories under `tests/ui/` [#5 of Batch #2])
 - #147438 (Rename "non-inline module" to "file module" in proc macro diagnostics)
 - #147724 (Fix ICE in pattern matching with generic const array length errors)
 - #147813 (Warn on unused_attributes in uitests )
 - #147816 (Do not error out for `download-rustc` if LTO is configured)
 - #147845 (Add regression test for 134355)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e53b361 into rust-lang:master Oct 19, 2025
11 checks passed
@rustbot rustbot added this to the 1.92.0 milestone Oct 19, 2025
rust-timer added a commit that referenced this pull request Oct 19, 2025
@rust-timer
Unrolled build for #147724
e43a0c0 
Rollup merge of #147724 - chenyukang:yukang-fix-139815-ice, r=jdonszelmann

Fix ICE in pattern matching with generic const array length errors

Fixes #139815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jdonszelmann jdonszelmann

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.92.0

Development

Successfully merging this pull request may close these issues.

ICE: expected len of array pat to be definite

5 participants

@chenyukang @rustbot @rust-log-analyzer @jdonszelmann @bors