-
Notifications
You must be signed in to change notification settings - Fork 14k
Add support for loading plugins via command line (fixes #15446) #20032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8751377 to
8774dab
Compare
|
🙌 |
|
Needs tests. You can use |
|
@kmcallister example of a test that makes a plugin and tests it? |
|
Look at which refers to a file in |
8774dab to
5b7175b
Compare
|
@kmcallister Done |
|
Can these plugins be loaded from the command line through |
|
needs rebase. i. want. |
|
@seanmonstar Yeah, I'm rebasing this every few days. :) |
|
@tomjakubowski Such libraries should load it via the usual method IMO. While this can be used for syntax extensions, it's mainly aimed at lints. |
|
Well any code with |
b624706 to
7c46180
Compare
7c46180 to
0f20b0b
Compare
067fdb3 to
4664db4
Compare
4664db4 to
6c32624
Compare
44b7b0f to
f4a2672
Compare
0e7f937 to
6342aa6
Compare
`rustc something.rs -L folder_with_plugin_dylib/ -Z extra-plugins=foo` works via this My way of testing this is by cloning https://github.com/Manishearth/rust-clippy, `cargo build`ing it, and then running `rustc examples/box_vec.rs -L target/ -Z extra-plugins=rust_clippy` after editing out the `exern crate rust_clippy` from `box_vec.rs` r? @huonw fixes #15446
minor: Sync from downstream
minor: Sync from downstream
rustc something.rs -L folder_with_plugin_dylib/ -Z extra-plugins=fooworks via thisMy way of testing this is by cloning https://github.com/Manishearth/rust-clippy,
cargo building it, and then runningrustc examples/box_vec.rs -L target/ -Z extra-plugins=rust_clippyafter editing out theexern crate rust_clippyfrombox_vec.rsr? @huonw
fixes #15446