Skip to content

Conversation

@tshepang
Copy link
Member

@tshepang tshepang commented Dec 3, 2015

No description provided.

@rust-highfive
Copy link
Contributor

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@steveklabnik
Copy link
Contributor

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Dec 3, 2015

📌 Commit 3e7498d has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Dec 4, 2015

💔 Test failed - auto-mac-32-opt

@tshepang
Copy link
Member Author

tshepang commented Dec 4, 2015

ah, missing use std::str::FromStr

@alexcrichton
Copy link
Member

This should use .parse() instead of the less-idiomatic ::from_str most likely as well.

@tshepang
Copy link
Member Author

tshepang commented Dec 6, 2015

Is that more like it @alexcrichton?

@alexcrichton
Copy link
Member

@bors: r+ 8569ef2

@bors
Copy link
Collaborator

bors commented Dec 7, 2015

⌛ Testing commit 8569ef2 with merge 7b77f67...

@bors bors merged commit 8569ef2 into rust-lang:master Dec 7, 2015
@tshepang tshepang deleted the lookup_addr-example branch December 7, 2015 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants