debuginfo: Revert to old/more verbose behavior for -Cdebuginfo=1 #61007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-lang@cff075009 made LLVM emit less debuginfo when compiling with "line-tables-only". The change was essentially correct but the reduced amount of debuginfo broke a number of tools. This commit reverts the change so we get back the old behavior, until we figure out how to do this properly and give external tools to adapt to the new format. See rust-lang#60020 for more info.
rust-highfive
added
the
S-waiting-on-review
|
@bors: r+ Definitely fixes issues seen over at #60852 (comment), so seems like we should land this! |
|
📌 Commit 46e3d04 has been approved by |
bors
added
S-waiting-on-bors
cuviper
approved these changes
May 21, 2019
bors
added a commit
that referenced
this pull request
May 21, 2019
…hton debuginfo: Revert to old/more verbose behavior for -Cdebuginfo=1 cff075009 made LLVM emit less debuginfo when compiling with "line-tables-only". The change was essentially correct but the reduced amount of debuginfo broke a number of tools. This commit reverts the change so we get back the old behavior, until we figure out how to do this properly and give external tools to adapt to the new format. See #60020 for more info. r? @cuviper cc @jrmuizel & @froydnj
|
☀️ Test successful - checks-travis, status-appveyor |
michaelwoerister
added
the
beta-nominated
|
Nominating for backporting to beta. |
michaelwoerister
added
the
T-compiler
|
accepted for beta-backport |
pnkfelix
added
the
beta-accepted
michaelwoerister
removed
the
beta-nominated
pietroalbini
added
the
beta-nominated
pietroalbini
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
May 29, 2019
[beta] Rollup backports Rolled up: * [beta] adjust deprecation date of mem::uninitialized #61160 Cherry-picked: * Fix ICE with inconsistent macro matchers #61046 * Revert "Add implementations of last in terms of next_back on a bunch of DoubleEndedIterators." #61057 * debuginfo: Revert to old/more verbose behavior for -Cdebuginfo=1 #61007 r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cff075009 made LLVM emit less debuginfo when compiling with "line-tables-only". The change was essentially correct but the reduced amount of debuginfo broke
a number of tools.
This commit reverts the change so we get back the old behavior, until we figure out how to do this properly and give external tools to adapt to the new format.
See #60020 for more info.
r? @cuviper
cc @jrmuizel & @froydnj