Switch the --browser argument to --web
#1328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2019
This commit reverts part of the implementation of [RFC 6]. That RFC specified that the `--browser` flag was going to be repurposed for the new "natively loadable as ES module output", but unfortunately the breakage is far broader than initially expected. It turns out that `wasm-pack` passes `--browser` by default which means that a change to break `--browser` would break all historical versions of `wasm-pack` which is a bit much for now. To solve this the `--browser` flag is going back to what it represents on the current released version of `wasm-bindgen` (optimize away some node.js checks in a few places for bundler-style output) and a new `--web` flag is being introduced as the new deployment strategy. [RFC 6]: rustwasm/rfcs#6 Closes wasm-bindgen#1318
alexcrichton
force-pushed
the
switch-to-web
branch
from
7f8eca6 to
cd3781c
Compare
fitzgen
approved these changes
Mar 7, 2019
Co-Authored-By: alexcrichton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverts part of the implementation of RFC 6. That RFC
specified that the
--browserflag was going to be repurposed for thenew "natively loadable as ES module output", but unfortunately the
breakage is far broader than initially expected. It turns out that
wasm-packpasses--browserby default which means that a change tobreak
--browserwould break all historical versions ofwasm-packwhich is a bit much for now.
To solve this the
--browserflag is going back to what it representson the current released version of
wasm-bindgen(optimize away somenode.js checks in a few places for bundler-style output) and a new
--webflag is being introduced as the new deployment strategy.Closes #1318