Skip to content

Commit e67aa96

Browse files
authored
Core: Combine Action and GenericAction (elastic#31405)
Since elastic#30966, Action no longer has anything but a call to the GenericAction super constructor. This commit renames GenericAction into Action, thus eliminating the Action class. Additionally, this commit removes the Request generic parameter of the class, since it was unused.
1 parent 4ad334f commit e67aa96

File tree

260 files changed

+359
-400
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

260 files changed

+359
-400
lines changed

client/client-benchmark-noop-api-plugin/src/main/java/org/elasticsearch/plugin/noop/action/bulk/NoopBulkAction.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,9 @@
1919
package org.elasticsearch.plugin.noop.action.bulk;
2020

2121
import org.elasticsearch.action.Action;
22-
import org.elasticsearch.action.bulk.BulkRequest;
2322
import org.elasticsearch.action.bulk.BulkResponse;
2423

25-
public class NoopBulkAction extends Action<BulkRequest, BulkResponse> {
24+
public class NoopBulkAction extends Action<BulkResponse> {
2625
public static final String NAME = "mock:data/write/bulk";
2726

2827
public static final NoopBulkAction INSTANCE = new NoopBulkAction();

client/client-benchmark-noop-api-plugin/src/main/java/org/elasticsearch/plugin/noop/action/search/NoopSearchAction.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,9 @@
1919
package org.elasticsearch.plugin.noop.action.search;
2020

2121
import org.elasticsearch.action.Action;
22-
import org.elasticsearch.action.search.SearchRequest;
2322
import org.elasticsearch.action.search.SearchResponse;
2423

25-
public class NoopSearchAction extends Action<SearchRequest, SearchResponse> {
24+
public class NoopSearchAction extends Action<SearchResponse> {
2625
public static final NoopSearchAction INSTANCE = new NoopSearchAction();
2726
public static final String NAME = "mock:data/read/search";
2827

modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/GrokProcessorGetAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
import static org.elasticsearch.rest.RestRequest.Method.GET;
5353
import static org.elasticsearch.rest.RestStatus.OK;
5454

55-
public class GrokProcessorGetAction extends Action<GrokProcessorGetAction.Request, GrokProcessorGetAction.Response> {
55+
public class GrokProcessorGetAction extends Action<GrokProcessorGetAction.Response> {
5656

5757
public static final GrokProcessorGetAction INSTANCE = new GrokProcessorGetAction();
5858
public static final String NAME = "cluster:admin/ingest/processor/grok/get";

modules/lang-mustache/src/main/java/org/elasticsearch/script/mustache/MultiSearchTemplateAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
import org.elasticsearch.action.Action;
2323

24-
public class MultiSearchTemplateAction extends Action<MultiSearchTemplateRequest, MultiSearchTemplateResponse> {
24+
public class MultiSearchTemplateAction extends Action<MultiSearchTemplateResponse> {
2525

2626
public static final MultiSearchTemplateAction INSTANCE = new MultiSearchTemplateAction();
2727
public static final String NAME = "indices:data/read/msearch/template";

modules/lang-mustache/src/main/java/org/elasticsearch/script/mustache/SearchTemplateAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
import org.elasticsearch.action.Action;
2323

24-
public class SearchTemplateAction extends Action<SearchTemplateRequest, SearchTemplateResponse> {
24+
public class SearchTemplateAction extends Action<SearchTemplateResponse> {
2525

2626
public static final SearchTemplateAction INSTANCE = new SearchTemplateAction();
2727
public static final String NAME = "indices:data/read/search/template";

modules/lang-painless/src/main/java/org/elasticsearch/painless/PainlessExecuteAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
import static org.elasticsearch.rest.RestRequest.Method.POST;
6363
import static org.elasticsearch.rest.RestStatus.OK;
6464

65-
public class PainlessExecuteAction extends Action<PainlessExecuteAction.Request, PainlessExecuteAction.Response> {
65+
public class PainlessExecuteAction extends Action<PainlessExecuteAction.Response> {
6666

6767
static final PainlessExecuteAction INSTANCE = new PainlessExecuteAction();
6868
private static final String NAME = "cluster:admin/scripts/painless/execute";

modules/rank-eval/src/main/java/org/elasticsearch/index/rankeval/RankEvalAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
/**
2525
* Action for explaining evaluating search ranking results.
2626
*/
27-
public class RankEvalAction extends Action<RankEvalRequest, RankEvalResponse> {
27+
public class RankEvalAction extends Action<RankEvalResponse> {
2828

2929
public static final RankEvalAction INSTANCE = new RankEvalAction();
3030
public static final String NAME = "indices:data/read/rank_eval";

modules/rank-eval/src/main/java/org/elasticsearch/index/rankeval/RankEvalRequestBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626
public class RankEvalRequestBuilder extends ActionRequestBuilder<RankEvalRequest, RankEvalResponse> {
2727

28-
public RankEvalRequestBuilder(ElasticsearchClient client, Action<RankEvalRequest, RankEvalResponse> action,
28+
public RankEvalRequestBuilder(ElasticsearchClient client, Action<RankEvalResponse> action,
2929
RankEvalRequest request) {
3030
super(client, action, request);
3131
}

modules/reindex/src/main/java/org/elasticsearch/index/reindex/AbstractBaseReindexRestHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
package org.elasticsearch.index.reindex;
2121

2222
import org.elasticsearch.action.ActionRequestValidationException;
23-
import org.elasticsearch.action.GenericAction;
23+
import org.elasticsearch.action.Action;
2424
import org.elasticsearch.action.support.ActiveShardCount;
2525
import org.elasticsearch.client.node.NodeClient;
2626
import org.elasticsearch.common.settings.Settings;
@@ -38,7 +38,7 @@
3838

3939
public abstract class AbstractBaseReindexRestHandler<
4040
Request extends AbstractBulkByScrollRequest<Request>,
41-
A extends GenericAction<Request, BulkByScrollResponse>
41+
A extends Action<BulkByScrollResponse>
4242
> extends BaseRestHandler {
4343

4444
private final A action;

modules/reindex/src/main/java/org/elasticsearch/index/reindex/AbstractBulkByQueryRestHandler.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
package org.elasticsearch.index.reindex;
2121

22-
import org.elasticsearch.action.GenericAction;
22+
import org.elasticsearch.action.Action;
2323
import org.elasticsearch.action.search.SearchRequest;
2424
import org.elasticsearch.common.bytes.BytesReference;
2525
import org.elasticsearch.common.settings.Settings;
@@ -38,7 +38,7 @@
3838
*/
3939
public abstract class AbstractBulkByQueryRestHandler<
4040
Request extends AbstractBulkByScrollRequest<Request>,
41-
A extends GenericAction<Request, BulkByScrollResponse>> extends AbstractBaseReindexRestHandler<Request, A> {
41+
A extends Action<BulkByScrollResponse>> extends AbstractBaseReindexRestHandler<Request, A> {
4242

4343
protected AbstractBulkByQueryRestHandler(Settings settings, A action) {
4444
super(settings, action);

0 commit comments

Comments
 (0)