gh-36141: Use system python packages with --enable-system-site-packages
    
Rebased branch of #29665

Platform-specific testing:
- for example TARGETS_PRE="build-local" tox -e docker-ubuntu-focal-
standard-sitepackages -- build ptest

Fixes #29665
    
URL: #36141
Reported by: Michael Orlitzky
Reviewer(s): Dima Pasechnik, Matthias Köppe, Michael Orlitzky

Author: Release Manager

.github/workflows/ci-linux.yml

@@ -63,6 +63,56 @@ jobs:
           ["standard"]
       docker_push_repository: ghcr.io/${{ github.repository }}/
 
+  standard-sitepackages:
+    if: ${{ success() || failure() }}
+    needs: [standard-pre]
+    uses: ./.github/workflows/docker.yml
+    with:
+      # Build incrementally from previous stage (pre)
+      incremental: true
+      free_disk_space: true
+      from_docker_repository: ghcr.io/${{ github.repository }}/
+      from_docker_target: "with-targets-pre"
+      docker_targets: "with-targets with-targets-optional"
+      # FIXME: duplicated from env.TARGETS
+      targets: build doc-html
+      targets_optional: ptest
+      tox_packages_factors: >-
+        ["standard-sitepackages"]
+      # Only test systems with a usable system python (>= 3.9)
+      tox_system_factors: >-
+        ["ubuntu-jammy",
+         "ubuntu-kinetic",
+         "ubuntu-lunar",
+         "ubuntu-mantic",
+         "debian-bullseye",
+         "debian-bookworm",
+         "debian-trixie",
+         "debian-sid",
+         "linuxmint-21",
+         "linuxmint-21.1",
+         "linuxmint-21.2",
+         "fedora-33",
+         "fedora-34",
+         "fedora-35",
+         "fedora-36",
+         "fedora-37",
+         "fedora-38",
+         "fedora-39",
+         "centos-stream-8-python3.9",
+         "centos-stream-9-python3.9",
+         "almalinux-8-python3.9",
+         "gentoo-python3.10",
+         "gentoo-python3.11",
+         "archlinux-latest",
+         "opensuse-15.4-gcc_11-python3.10",
+         "opensuse-15.5-gcc_11-python3.11",
+         "opensuse-tumbleweed-python3.10",
+         "opensuse-tumbleweed",
+         "debian-bullseye-i386"]
+      docker_push_repository: ghcr.io/${{ github.repository }}/
+      max_parallel: 10
+
   minimal-pre:
     if: ${{ success() || failure() }}
     # It does not really "need" it.

.github/workflows/docker.yml

@@ -57,6 +57,7 @@ on:
            "opensuse-15.4-gcc_11-python3.10",
            "opensuse-15.5-gcc_11-python3.11",
            "opensuse-tumbleweed-python3.10",
+           "opensuse-tumbleweed",
            "conda-forge",
            "ubuntu-bionic-gcc_8-i386",
            "debian-bullseye-i386",

build/bin/sage-build-env-config.in

@@ -53,9 +53,13 @@ export SAGE_PARI_CFG="@SAGE_PARI_CFG@"
 
 export SAGE_GLPK_PREFIX="@SAGE_GLPK_PREFIX@"
 export SAGE_FREETYPE_PREFIX="@SAGE_FREETYPE_PREFIX@"
+export SAGE_PIP_INSTALL_FLAGS="@SAGE_PIP_INSTALL_FLAGS@"
 export SAGE_SUITESPARSE_PREFIX="@SAGE_SUITESPARSE_PREFIX@"
 
 export SAGE_CONFIGURE_FFLAS_FFPACK="@SAGE_CONFIGURE_FFLAS_FFPACK@"
 
 export CONFIGURED_SAGE_EDITABLE="@SAGE_EDITABLE@"
 export CONFIGURED_SAGE_WHEELS="@SAGE_WHEELS@"
+
+export ENABLE_SYSTEM_SITE_PACKAGES="@ENABLE_SYSTEM_SITE_PACKAGES@"
+export PYTHON_MINOR="@PYTHON_MINOR@"

build/bin/sage-dist-helpers

@@ -325,7 +325,11 @@ sdh_store_wheel() {
 }
 
 sdh_store_and_pip_install_wheel() {
-    local pip_options=""
+    # The $SAGE_PIP_INSTALL_FLAGS variable is set by sage-build-env-config.
+    # We skip sanity checking its contents since you should either let sage
+    # decide what it contains, or really know what you are doing.
+    local pip_options="${SAGE_PIP_INSTALL_FLAGS}"
+
     while [ $# -gt 0 ]; do
         case $1 in
             -*) pip_options="$pip_options $1"

build/bin/sage-get-system-packages

@@ -1,4 +1,5 @@
 #!/bin/sh
+
 SYSTEM=$1
 if [ -z "$SYSTEM" ]; then
    echo >&2 "usage: $0 {auto|debian|arch|conda|pip|...} SPKGS..."
@@ -10,6 +11,7 @@ SPKGS="$*"
 if [ -z "$SAGE_ROOT" ]; then
     SAGE_ROOT=`pwd`
 fi
+
 case "$SYSTEM" in
     install-requires)
         # Collect install-requires.txt (falling back to requirements.txt) and output it in the format
@@ -44,6 +46,18 @@ case "$SYSTEM" in
         ;;
 esac
 for PKG_BASE in $SPKGS; do
+
+    # Skip this package if it uses the SAGE_PYTHON_PACKAGE_CHECK
+    # macro and if --enable-system-site-packages was NOT passed
+    # to ./configure (or if ./configure has not yet been run).
+    SPKG_CONFIGURE="${SAGE_ROOT}/build/pkgs/${PKG_BASE}/spkg-configure.m4"
+    if [ -z "${ENABLE_SYSTEM_SITE_PACKAGES}" ]; then
+        if grep -q SAGE_PYTHON_PACKAGE_CHECK "${SPKG_CONFIGURE}" 2>/dev/null;
+        then
+            continue;
+        fi
+    fi
+
     for NAME in $SYSTEM_PACKAGES_FILE_NAMES; do
         SYSTEM_PACKAGES_FILE="$SAGE_ROOT"/build/pkgs/$PKG_BASE/$NAME
         if [ -f $SYSTEM_PACKAGES_FILE ]; then

build/bin/sage-spkg-info

@@ -110,17 +110,19 @@ if [ -z "$system" ]; then
     echo "(none known)"
 else
     echo
-    if [ -f "$PKG_SCRIPTS"/spkg-configure.m4 ]; then
-        echo "If the system package is installed, ./configure will check whether it can be used."
-    else
-        echo "However, these system packages will not be used for building Sage"
-        if [ -f "$PKG_SCRIPTS"/install-requires.txt ]; then
-            echo "because using Python site-packages is not supported by the Sage distribution;"
-            echo "see https://github.com/sagemath/sage/issues/29023"
+    SPKG_CONFIGURE="${PKG_SCRIPTS}/spkg-configure.m4"
+    if [ -f "${SPKG_CONFIGURE}" ]; then
+        if grep -q SAGE_PYTHON_PACKAGE_CHECK "${SPKG_CONFIGURE}"; then
+            echo "If the system package is installed and if the (experimental) option"
+            echo "--enable-system-site-packages is passed to ./configure, then ./configure"
+            echo "will check if the system package can be used."
         else
-            echo "because spkg-configure.m4 has not been written for this package;"
-            echo "see https://github.com/sagemath/sage/issues/27330"
+            echo "If the system package is installed, ./configure will check if it can be used."
         fi
+    else
+        echo "However, these system packages will not be used for building Sage"
+        echo "because spkg-configure.m4 has not been written for this package;"
+        echo "see https://github.com/sagemath/sage/issues/27330"
     fi
 fi
 echo

build/bin/write-dockerfile.sh

@@ -5,7 +5,7 @@
 set -e
 SYSTEM="${1:-debian}"
 shopt -s extglob
-SAGE_PACKAGE_LIST_ARGS="${2:- --has-file=spkg-configure.m4 :standard:}"
+SAGE_PACKAGE_LIST_ARGS="${2:-:standard:}"
 WITH_SYSTEM_SPKG="${3:-yes}"
 IGNORE_MISSING_SYSTEM_PACKAGES="${4:-no}"
 EXTRA_SAGE_PACKAGES="${5:-_bootstrap}"
@@ -15,17 +15,13 @@ SAGE_ROOT=.
 export PATH="$SAGE_ROOT"/build/bin:$PATH
 SYSTEM_PACKAGES=$EXTRA_SYSTEM_PACKAGES
 CONFIGURE_ARGS="--enable-option-checking "
-for PKG_BASE in $(sage-package list --has-file=distros/$SYSTEM.txt $SAGE_PACKAGE_LIST_ARGS) $EXTRA_SAGE_PACKAGES; do
-    PKG_SCRIPTS="$SAGE_ROOT"/build/pkgs/$PKG_BASE
-    if [ -d $PKG_SCRIPTS ]; then
-       SYSTEM_PACKAGES_FILE=$PKG_SCRIPTS/distros/$SYSTEM.txt
-       PKG_SYSTEM_PACKAGES=$(echo $(${STRIP_COMMENTS} $SYSTEM_PACKAGES_FILE))
-       if [ -n "PKG_SYSTEM_PACKAGES" ]; then
-           SYSTEM_PACKAGES+=" $PKG_SYSTEM_PACKAGES"
-           if [ -f $PKG_SCRIPTS/spkg-configure.m4 ]; then
-               CONFIGURE_ARGS+="--with-system-$PKG_BASE=${WITH_SYSTEM_SPKG} "
-           fi
-       fi
+for SPKG in $(sage-package list --has-file=spkg-configure.m4 $SAGE_PACKAGE_LIST_ARGS) $EXTRA_SAGE_PACKAGES; do
+    SYSTEM_PACKAGE=$(sage-get-system-packages $SYSTEM $SPKG | sed 's/${PYTHON_MINOR}/'${PYTHON_MINOR}'/g')
+    if [ -n "${SYSTEM_PACKAGE}" ]; then
+	# SYSTEM_PACKAGE can be empty if, for example, the environment
+	# variable ENABLE_SYSTEM_SITE_PACKAGES is empty.
+	SYSTEM_PACKAGES+=" ${SYSTEM_PACKAGE}"
+	CONFIGURE_ARGS+="--with-system-${SPKG}=${WITH_SYSTEM_SPKG} "
     fi
 done
 echo "# Automatically generated by SAGE_ROOT/build/bin/write-dockerfile.sh"

build/make/Makefile.in

@@ -227,22 +227,29 @@ SAGE_I_TARGETS = sagelib doc
 	python3_venv _clean-broken-gcc
 
 PYTHON_FOR_VENV = @PYTHON_FOR_VENV@
+PYTHON_MINOR = @PYTHON_MINOR@
+SAGE_VENV_FLAGS = @SAGE_VENV_FLAGS@
 
 ifneq ($(PYTHON_FOR_VENV),)
 # Special rule for making the Python virtualenv from the system Python (Python
 # 3 only).  $(PYTHON) is set in Makefile to python3_venv.
-# Thus $(inst_python3_venv) will be the dependency of every Python package.
+# Thus $(inst_python3_venv) will an (order-only) dependency of every Python package.
 #
 # TODO: If we reconfigure to build our own Python after having used the system
 # Python, files installed to create the virtualenv should be *removed*.  That
 # could either be done here by the makefile, or in an spkg-preinst for python3
 ifeq ($(PYTHON),python3)
 PYTHON = python3_venv
 endif
-inst_python3_venv = $(SAGE_VENV)/pyvenv.cfg
+inst_python3_venv = $(SAGE_VENV)/$(SPKG_INST_RELDIR)/python3_venv-3.$(PYTHON_MINOR)-$(subst /,-,$(PYTHON_FOR_VENV))$(findstring --system-site-packages,$(SAGE_VENV_FLAGS))
 
-$(inst_python3_venv):
-	$(PYTHON_FOR_VENV) $(SAGE_ROOT)/build/bin/sage-venv "$(SAGE_VENV)"
+$(SAGE_VENV)/$(SPKG_INST_RELDIR):
+	mkdir -p "$@"
+
+$(inst_python3_venv): | $(SAGE_VENV)/$(SPKG_INST_RELDIR)
+	$(PYTHON_FOR_VENV) $(SAGE_ROOT)/build/bin/sage-venv $(SAGE_VENV_FLAGS) "$(SAGE_VENV)"
+	rm -f "$(SAGE_VENV)/$(SPKG_INST_RELDIR)"/python3_venv-*
+	touch "$@"
 endif
 
 # Build everything and start Sage.

build/pkgs/admcycles/dependencies

@@ -1,4 +1,4 @@
-$(PYTHON) | $(PYTHON_TOOLCHAIN)
+ | $(PYTHON_TOOLCHAIN) $(PYTHON)
 
 ----------
 All lines of this file are ignored except the first.

build/pkgs/alabaster/dependencies

@@ -1,4 +1,4 @@
-$(PYTHON) | $(PYTHON_TOOLCHAIN)
+ | $(PYTHON_TOOLCHAIN) $(PYTHON)
 
 ----------
 All lines of this file are ignored except the first.