Sage package for Perl 5 readline library

[mkoeppe]

This is a prerequisite for building Polymake (#20892) on Mac OS X.

http://search.cpan.org/~hayashi/Term-ReadLine-Gnu-1.34/

http://search.cpan.org/CPAN/authors/id/H/HA/HAYASHI/Term-ReadLine-Gnu-1.34.tar.gz

CC: @videlec @vbraun @embray @jdemeyer @dimpase @kcrisman @tscrim

Component: packages: experimental

Author: Matthias Koeppe

Branch/Commit: cfffc5e

Reviewer: Karl-Dieter Crisman, Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/20894

[mkoeppe]

Description changed:

--- 
+++ 
@@ -2,3 +2,4 @@
 
 http://search.cpan.org/~hayashi/Term-ReadLine-Gnu-1.34/
 
+http://search.cpan.org/CPAN/authors/id/H/HA/HAYASHI/Term-ReadLine-Gnu-1.34.tar.gz

[mkoeppe]

Branch: u/mkoeppe/sage_package_for_perl_5_readline_library

[mkoeppe]

comment:3

Not sure if this installation should be done using CPAN scripts instead.

---

New commits:

3c5a4ac	Add Sage package for Perl 5 readline library
ac47794	Set PERL5LIB environment variable

[mkoeppe]

Commit: ac47794

[kcrisman]

comment:5

This always was a big part of the struggle for me in getting this to work on Mac. Hopefully it can be portable to pre-10.11 as well but at least if it is working on some OS X it will be a huge improvement - I regularly see papers citing polymake or latte which could be using Sage to interface better with them and other stuff.

[kcrisman]

comment:6

There is a problem in the way we do things now with experimental packages. Here is what I saw:

make[1]: warning: -jN forced in submake: disabling jobserver mode.
sage-logger -p 'sage-spkg  perl_term_readline_gnu-1.34' '/Users/karl.crisman/Downloads/sage/logs/pkgs/perl_term_readline_gnu-1.34.log'
[perl_term_readline_gnu-1.34] Found local metadata for perl_term_readline_gnu-1.34
[perl_term_readline_gnu-1.34] =========================== WARNING ===========================
[perl_term_readline_gnu-1.34] You are about to download and install an experimental package.
[perl_term_readline_gnu-1.34] This probably won't work at all for you! There is no guarantee
[perl_term_readline_gnu-1.34] that it will build correctly, or behave as expected.
[perl_term_readline_gnu-1.34] Use at your own risk!
[perl_term_readline_gnu-1.34] ===============================================================
<hang>

but actually it was waiting for me to answer

[perl_term_readline_gnu-1.34] Are you sure you want to continue [Y/n]? 

which the second time I did. In the old ./sage -i this worked okay, but somehow with the new logging system it sort of failed. Don't know if fixing this belongs on this ticket, though. (Jeroen, I think you've tried out more experimental packages than most - thoughts?)

[kcrisman]

comment:7

But #20892 still does:

[polymake-3.0r1] Thread model: posix
[polymake-3.0r1] gcc version 4.9.3 (GCC) 
[polymake-3.0r1] ****************************************************
[polymake-3.0r1] checking C++ compiler ... ok (g++ is GCC 4.9.3)
[polymake-3.0r1] checking C++ library ... ok (GNU stdlibc++ 20150626, C++ 199711)
[polymake-3.0r1] checking fink installation ... The Fink package system is a mandatory prerequisite to build and use polymake under MacOS.
[polymake-3.0r1] Please refer to http://www.polymake.org/doku.php/mac for details and installation instructions.
[polymake-3.0r1] If you already have Fink installed at a non-standard location, please specify it using option --with-fink
[polymake-3.0r1] Several configurations for MacOS platform found;
[polymake-3.0r1] Please specify the desired one using the option Arch=<NAME>.
[polymake-3.0r1] Makefile:32: *** CONFIGURATION ERROR.  Stop.
[polymake-3.0r1] Several configurations for MacOS platform found;
[polymake-3.0r1] Please specify the desired one using the option Arch=<NAME>.
[polymake-3.0r1] Makefile:32: *** CONFIGURATION ERROR.  Stop.
[polymake-3.0r1] 
[polymake-3.0r1] real	0m1.003s
[polymake-3.0r1] user	0m0.415s
[polymake-3.0r1] sys	0m0.219s
[polymake-3.0r1] ************************************************************************
[polymake-3.0r1] Error installing package polymake-3.0r1
[polymake-3.0r1] ************************************************************************

I see you have some special instructions at #20892 comment:17 so I'll try that.

[kcrisman]

comment:8

Apparently this is working well enough that I'd say one could give it positive review (modulo comment:6, if relevant). But I would like to hear from Linuces. I have to admit I was never successful in getting this to work on my older Mac but apparently the Perl part actually does here!

[mkoeppe]

comment:9

Replying to @kcrisman:

There is a problem in the way we do things now with experimental packages. Here is what I saw:

<hang>

but actually it was waiting for me to answer

[perl_term_readline_gnu-1.34] Are you sure you want to continue [Y/n]? 

which the second time I did.

This is bug #20884.

[mkoeppe]

Author: Matthias Koeppe

[kcrisman]

comment:11

Okay, then I think all we need for positive review is someone to test this doesn't break anything. (E.g. on Linux or Cygwin...) Very nice!

[kcrisman]

Reviewer: Karl-Dieter Crisman

[sagetrac-tmonteil]

comment:12

The ARCHFLAGS='-arch x86_64' looks weird. How does it behaves on other architectures ?

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

4088bec	Merge tag '7.3.beta6' into t/20894/sage_package_for_perl_5_readline_library
cfffc5e	Conditionalize ARCHFLAGS based on uname

[sagetrac-git]

Changed commit from ac47794 to cfffc5e