sage.misc.latex: Replace have_... functions by Features

[mkoeppe]

... or more generally, replacing all uses of sage.misc.os_tools.have_program by Executable

Depends on #32634

CC: @kwankyu

Component: refactoring

Author: Sébastien Labbé

Branch: 2ea4d9e

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/32650

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1 +1 @@
-
+... or more generally, replacing all uses of `sage.misc.os_tools.have_program` by `Executable`

[seblabbe]

Commit: f3291d8

[seblabbe]

Author: Sébastien Labbé

[seblabbe]

comment:2

Here is some work towards that goal removing all uses of have_program in misc/latex.py.

---

New commits:

8068ba5	32650: Creating feature dvipng
a96e94d	32650: Creating feature pdf2svg
870d461	32650: Creating features latex, xelatex, pdflatex, lualatex
385569e	32650: adding latex, xelatex, pdflatex, lualatex, pdf2svg, dvipng to doctest/external.py
f3291d8	32650: using features instead of have_program in misc/latex.py

[seblabbe]

Branch: u/slabbe/32650

[seblabbe]

comment:3

Remainings usage of have_program are:

$ git grep have_program
interfaces/chomp.py:        from sage.misc.sage_ostools import have_program
interfaces/chomp.py:        _have_chomp[program] = have_program(program)
interfaces/phc.py:            from sage.misc.sage_ostools import have_program
interfaces/phc.py:            if not have_program('phc'):
misc/dist.py:    from sage.misc.sage_ostools import have_program
misc/dist.py:        cmd_inside_sage = have_program(cmd, path=SAGE_BIN)
misc/dist.py:        cmd_outside_sage = have_program(cmd, path=PATH)
misc/sage_ostools.pyx:def have_program(program, path=None):
misc/sage_ostools.pyx:        sage: from sage.misc.sage_ostools import have_program
misc/sage_ostools.pyx:        sage: have_program('ls')
misc/sage_ostools.pyx:        sage: have_program('there_is_not_a_program_with_this_name')
misc/sage_ostools.pyx:        sage: have_program('sage', os.path.join(SAGE_VENV, 'bin'))
misc/sage_ostools.pyx:        sage: have_program('sage', '/there_is_not_a_path_with_this_name')
misc/sage_ostools.pyx:        sage: have_program('there_is_not_a_program_with_this_name', os.path.join(SAGE_VENV, 'bin'))
misc/viewer.py:    from sage.misc.sage_ostools import have_program
misc/viewer.py:    elif have_program('xdg-open'):
misc/viewer.py:                if have_program(cmd):
misc/viewer.py:                if have_program(cmd):
misc/viewer.py:                if have_program(cmd):
plot/animate.py:        from sage.misc.sage_ostools import have_program
plot/animate.py:        have_convert = have_program('convert')
plot/animate.py:        from sage.misc.sage_ostools import have_program
plot/animate.py:        return have_program('ffmpeg')
plot/graphics.py:                from sage.misc.sage_ostools import have_program
plot/graphics.py:                                         if have_program(i)]
plot/multigraphics.py:                from sage.misc.sage_ostools import have_program
plot/multigraphics.py:                                         if have_program(i)]

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

a5aebb9

32650: using features in plot/animate.py (currently with .require(need_msg) which is not yet supported)

[sagetrac-git]

Changed commit from f3291d8 to a5aebb9

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

2e9a6b1

32650: using features in plot/graphics.py and plot/multigraphics.py

[sagetrac-git]

Changed commit from a5aebb9 to 2e9a6b1

[seblabbe]

comment:6

I suggest this ticket should handle only the removal of have_program in misc.latex.py and sage.plot.

TODO: Answer this question: do we want .require(needed_for_msg) to provide an additional message explaining why the feature is needed for?

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ddd2287	32650: using features in plot/animate.py (currently with .require(need_msg) which is not yet supported)
d438c45	32650: using features in plot/graphics.py and plot/multigraphics.py

[sagetrac-git]

Changed commit from 2e9a6b1 to d438c45

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d455993	32650: using features in plot/animate.py
cf02094	32650: using features in plot/graphics.py and plot/multigraphics.py

[sagetrac-git]

Changed commit from d438c45 to cf02094