Follow-up to the fields added in #580, and add Problem#rendered #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A validation involving this pull request is in progress... |
|
The validator has checked the following projects against Scala 2.12,
❌ The result is: FAILED |
Contributor
Author
|
The validator is still broken: [scala-212] --== End Extracting dependencies for scala-212 ==--
[error] java.lang.RuntimeException:
[error]
[error] Fatal: multiple projects have the same artifacts visible in the same space.
[error]
[error] org.scala-sbt#zinc-classpath from sbt212-zinc and sbt212-zinc, both visible in space "sbt212"
[error] org.scala-sbt#zinc-apiinfo from sbt212-zinc and sbt212-zinc, both visible in space "sbt212"
[error] org.scala-sbt#zinc-classfile from sbt212-zinc and sbt212-zinc, both visible in space "sbt212"
[error] org.scala-sbt#compiler-bridge from sbt212-zinc and sbt212-zinc, both visible in space "sbt212"
[error]
[error] at scala.sys.package$.error(package.scala:27)
[error] at com.typesafe.dbuild.model.RepeatableDBuildConfig.<init>(RepeatableBuild.scala:158)
[error] at com.typesafe.dbuild.model.RepeatableDBuildConfigH$.fromExtractionOutcome(RepeatableBuild.scala:71)
Shutting down, please wait...
Result: EXTRACTION FAILED (Cause: RuntimeException: ) |
jvican
requested changes
Aug 28, 2018
Member
jvican
left a comment
jvican
left a comment
There was a problem hiding this comment.
👍 on the addition of rendered, aside from the comment this LGTM
| import sbinary.Format | ||
| import xsbti.{ Position, Problem, Severity } | ||
|
|
||
| // TODO: Remove this method once a version of sbinary containing |
Member
There was a problem hiding this comment.
You don't need to update the text analysis format since it's not supported anymore and it's not used by any build tool that I know of (and if somebody is using it, it's fine that they don't see the new additions to positions). We should probably remove this from this PR
Contributor
Author
There was a problem hiding this comment.
You don't need to update the text analysis format since it's not supported anymore
Then why isn't it deprecated? If it was, I wouldn't have wasted a day implementing this.
We should probably remove this from this PR
At this point I would just keep it since it avoids some deprecation warnings in the build of Zinc.
| } | ||
| } | ||
|
|
||
| private def fromString(value: String): Option[String] = |
Member
There was a problem hiding this comment.
Is indentation off here compared to fromInt?
Contributor
Author
There was a problem hiding this comment.
What do you mean? They're both indented the same way.
eed3si9n
approved these changes
Aug 29, 2018
This was forgotten in sbt#580. Also bump sbinary to 0.5.0 to make `asProduct13` from sbt/sbinary#17 available.
And bump util to 1.2.2 to include sbt/util#175
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Sep 14, 2018
Dotty has its own logic for displaying problems with the proper file path, position, and caret, but if we store this information in Problem#message we end up with duplicated information in the output since Zinc will prepend/append similar things (see sbt.internal.inc.ProblemStringFormats). So far, we worked around this in Dotty by using an empty position in the sbt bridge reporter, but this means that crucial semantic information that could be used by a Build Server Protocol implementation and other tools is lost. Thanks to sbt/zinc#588 we can now fully customize how the message is displayed to the user using Problem#rendered, so we can now store the position information without any adverse effect.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Sep 14, 2018
Dotty has its own logic for displaying problems with the proper file path, position, and caret, but if we store this information in Problem#message we end up with duplicated information in the output since Zinc will prepend/append similar things (see sbt.internal.inc.ProblemStringFormats). So far, we worked around this in Dotty by using an empty position in the sbt bridge reporter, but this means that crucial semantic information that could be used by a Build Server Protocol implementation and other tools is lost. Thanks to sbt/zinc#588 we can now fully customize how the message is displayed to the user using Problem#rendered, so we can now store the position information without any adverse effect.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Sep 14, 2018
Dotty has its own logic for displaying problems with the proper file path, position, and caret, but if we store this information in Problem#message we end up with duplicated information in the output since Zinc will prepend/append similar things (see sbt.internal.inc.ProblemStringFormats). So far, we worked around this in Dotty by using an empty position in the sbt bridge reporter, but this means that crucial semantic information that could be used by a Build Server Protocol implementation and other tools is lost. Thanks to sbt/zinc#588 we can now fully customize how the message is displayed to the user using Problem#rendered, so we can now store the position information without any adverse effect.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Sep 14, 2018
Dotty has its own logic for displaying problems with the proper file path, position, and caret, but if we store this information in Problem#message we end up with duplicated information in the output since Zinc will prepend/append similar things (see sbt.internal.inc.ProblemStringFormats). So far, we worked around this in Dotty by using an empty position in the sbt bridge reporter, but this means that crucial semantic information that could be used by a Build Server Protocol implementation and other tools is lost. Thanks to sbt/zinc#588 we can now fully customize how the message is displayed to the user using Problem#rendered, so we can now store the position information without any adverse effect.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Sep 14, 2018
Dotty has its own logic for displaying problems with the proper file path, position, and caret, but if we store this information in Problem#message we end up with duplicated information in the output since Zinc will prepend/append similar things (see sbt.internal.inc.ProblemStringFormats). So far, we worked around this in Dotty by using an empty position in the sbt bridge reporter, but this means that crucial semantic information that could be used by a Build Server Protocol implementation and other tools is lost. Thanks to sbt/zinc#588 we can now fully customize how the message is displayed to the user using Problem#rendered, so we can now store the position information without any adverse effect.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Sep 14, 2018
Dotty has its own logic for displaying problems with the proper file path, position, and caret, but if we store this information in Problem#message we end up with duplicated information in the output since Zinc will prepend/append similar things (see sbt.internal.inc.ProblemStringFormats). So far, we worked around this in Dotty by using an empty position in the sbt bridge reporter, but this means that crucial semantic information that could be used by a Build Server Protocol implementation and other tools is lost. Thanks to sbt/zinc#588 we can now fully customize how the message is displayed to the user using Problem#rendered, so we can now store the position information without any adverse effect.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Sep 14, 2018
Dotty has its own logic for displaying problems with the proper file path, position, and caret, but if we store this information in Problem#message we end up with duplicated information in the output since Zinc will prepend/append similar things (see sbt.internal.inc.ProblemStringFormats). So far, we worked around this in Dotty by using an empty position in the sbt bridge reporter, but this means that crucial semantic information that could be used by a Build Server Protocol implementation and other tools is lost. Thanks to sbt/zinc#588 we can now fully customize how the message is displayed to the user using Problem#rendered, so we can now store the position information without any adverse effect.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Sep 14, 2018
Dotty has its own logic for displaying problems with the proper file path, position, and caret, but if we store this information in Problem#message we end up with duplicated information in the output since Zinc will prepend/append similar things (see sbt.internal.inc.ProblemStringFormats). So far, we worked around this in Dotty by using an empty position in the sbt bridge reporter, but this means that crucial semantic information that could be used by a Build Server Protocol implementation and other tools is lost. Thanks to sbt/zinc#588 we can now fully customize how the message is displayed to the user using Problem#rendered, so we can now store the position information without any adverse effect.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Sep 14, 2018
Dotty has its own logic for displaying problems with the proper file path, position, and caret, but if we store this information in Problem#message we end up with duplicated information in the output since Zinc will prepend/append similar things (see sbt.internal.inc.ProblemStringFormats). So far, we worked around this in Dotty by using an empty position in the sbt bridge reporter, but this means that crucial semantic information that could be used by a Build Server Protocol implementation and other tools is lost. Thanks to sbt/zinc#588 we can now fully customize how the message is displayed to the user using Problem#rendered, so we can now store the position information without any adverse effect.
eed3si9n
pushed a commit
to eed3si9n/scala
that referenced
this pull request
May 14, 2019
Dotty has its own logic for displaying problems with the proper file path, position, and caret, but if we store this information in Problem#message we end up with duplicated information in the output since Zinc will prepend/append similar things (see sbt.internal.inc.ProblemStringFormats). So far, we worked around this in Dotty by using an empty position in the sbt bridge reporter, but this means that crucial semantic information that could be used by a Build Server Protocol implementation and other tools is lost. Thanks to sbt/zinc#588 we can now fully customize how the message is displayed to the user using Problem#rendered, so we can now store the position information without any adverse effect.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR requires a release of sbt util with sbt/util#175 merged.
After having a look at https://discuss.lightbend.com/t/patching-strategy/1924 I have no idea whether I'm supposed to open things against 1.2.x or 1.x, so I'm opening against 1.2.x since that's what I care about right now.