Skip to content

Conversation

@lisalupi
Copy link
Collaborator

@lisalupi lisalupi commented Oct 8, 2025

Summary

Type

  • Refactor

Summarise concisely:

What is expected?

Refactor component CodeEditor to use vanilla extract instead of Emotion

@lisalupi lisalupi requested a review from a team October 8, 2025 09:28
@lisalupi lisalupi self-assigned this Oct 8, 2025
@lisalupi lisalupi requested review from DorianMaliszewski and fabienhebert and removed request for a team October 8, 2025 09:28
@lisalupi lisalupi requested a review from matthprost as a code owner October 8, 2025 09:28
@lisalupi lisalupi added the refactor Refactor without breaking changes label Oct 8, 2025
@changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2025

🦋 Changeset detected

Latest commit: 9a845dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ultraviolet/plus Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lisalupi lisalupi force-pushed the refactor/code-editor branch from b418140 to 9a845dc Compare October 10, 2025 08:20
@lisalupi lisalupi merged commit afa989d into beta Oct 10, 2025
15 checks passed
@lisalupi lisalupi deleted the refactor/code-editor branch October 10, 2025 08:30
@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (107fe0e) to head (9a845dc).
⚠️ Report is 143 commits behind head on beta.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             beta   #5654       +/-   ##
==========================================
- Coverage   92.17%       0   -92.18%     
==========================================
  Files         289       0      -289     
  Lines        7615       0     -7615     
  Branches     3149       0     -3149     
==========================================
- Hits         7019       0     -7019     
+ Misses        596       0      -596     

see 289 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1212bbd...9a845dc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lisalupi added a commit that referenced this pull request Oct 22, 2025
* refactor: code editor vanilla extract

* fix: remove useless space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactor without breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants