[SP-2993] chore: rename min_cutoff_threshold to recursive_threshold

Author: matiasdaloia

internal/domain/entities/scan_request.go

@@ -4,8 +4,8 @@ package entities
 type ScanRequest struct {
 	// Get results with rank above this threshold (e.g i only want to see results from rank 3 and above)
 	RankThreshold int `validate:"omitempty,min=0"`
-	// Min cutoff threshold (e.g i only want to see results with score above this threshold)
-	MinCutoffThreshold float32 `validate:"omitempty,min=0"`
+	// Recursive threshold (e.g i only want to see results with score above this threshold)
+	RecursiveThreshold float32 `validate:"omitempty,min=0"`
 	// Filter results by category (e.g i only want to see results from github projects, npm, etc)
 	Category string
 	// Maximum number of results to query

internal/mapper/scan_mapper_impl.go

@@ -21,7 +21,7 @@ func (m *ScanMapperImpl) ProtoToDomain(req *scanningv2.HFHRequest) *entities.Sca
 
 	return &entities.ScanRequest{
 		RankThreshold:      int(req.RankThreshold),
-		MinCutoffThreshold: req.MinCutoffThreshold,
+		RecursiveThreshold: req.RecursiveThreshold,
 		Category:           req.Category,
 		QueryLimit:         int(req.QueryLimit),
 		Root:               m.ChildrenToDomain(req.Root),

internal/service/scan_service_impl.go

@@ -27,7 +27,7 @@ func (s *ScanServiceImpl) ScanFolder(ctx context.Context, req *entities.ScanRequ
 		return nil, err
 	}
 
-	results, err := s.scanNode(ctx, req.Root, req.RankThreshold, req.MinCutoffThreshold)
+	results, err := s.scanNode(ctx, req.Root, req.RankThreshold, req.RecursiveThreshold)
 	if err != nil {
 		return nil, err
 	}
@@ -63,7 +63,7 @@ func (s *ScanServiceImpl) processComponentGroups(componentGroups []entities.Comp
 	return results
 }
 
-func (s *ScanServiceImpl) scanNode(ctx context.Context, node *entities.FolderNode, rankThreshold int, minCutoffThreshold float32) ([]*entities.ScanResult, error) {
+func (s *ScanServiceImpl) scanNode(ctx context.Context, node *entities.FolderNode, rankThreshold int, recursiveThreshold float32) ([]*entities.ScanResult, error) {
 	logger := ctxzap.Extract(ctx).Sugar()
 
 	if node.SimHashDirNames == "" && node.SimHashNames == "" && node.SimHashContent == "" {
@@ -80,9 +80,9 @@ func (s *ScanServiceImpl) scanNode(ctx context.Context, node *entities.FolderNod
 
 	logger.Debugf("SearchByHashes returned %d component groups for node %s", len(componentGroups), node.PathID)
 
-	// Check if any component group has a version with score >= minCutoffThreshold
-	if minCutoffThreshold > 0 && s.hasHighScoreMatch(componentGroups, minCutoffThreshold) {
-		logger.Infof("Found high score match (>= %f) for node %s, stopping search", minCutoffThreshold, node.PathID)
+	// Check if any component group has a version with score >= recursiveThreshold
+	if recursiveThreshold > 0 && s.hasHighScoreMatch(componentGroups, recursiveThreshold) {
+		logger.Infof("Found high score match (>= %f) for node %s, stopping search", recursiveThreshold, node.PathID)
 		results := s.processComponentGroups(componentGroups, node.PathID)
 		return results, nil
 	}
@@ -91,7 +91,7 @@ func (s *ScanServiceImpl) scanNode(ctx context.Context, node *entities.FolderNod
 
 	if len(node.Children) > 0 {
 		for _, child := range node.Children {
-			childResults, err := s.scanNode(ctx, child, rankThreshold, minCutoffThreshold)
+			childResults, err := s.scanNode(ctx, child, rankThreshold, recursiveThreshold)
 			if err != nil {
 				return nil, err
 			}