Configure coalescing delay #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muzarski
requested review from
Lorak-mmk and
wprzytula
and removed request for
wprzytula
muzarski
force-pushed
the
coalesce_delay
branch
from
ca34b73 to
d61d87f
Compare
Lorak-mmk
approved these changes
Apr 15, 2025
wprzytula
requested changes
Apr 16, 2025
muzarski
force-pushed
the
coalesce_delay
branch
from
d61d87f to
95e61e7
Compare
|
v1.1: Addressed @wprzytula comments |
I also set the reasonable defaults. Implemented unit test for setting the delay.
muzarski
force-pushed
the
coalesce_delay
branch
from
95e61e7 to
796a675
Compare
|
v1.2: After applying @wprzytula suggestion, clippy found out that we can use |
wprzytula
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #238
This PR implements
cass_cluster_set_coalesce_delay.Pre-review checklist
[ ] I have enabled appropriate tests in.github/workflows/build.ymlingtest_filter.[ ] I have enabled appropriate tests in.github/workflows/cassandra.ymlingtest_filter.