Skip to content
This repository was archived by the owner on Apr 24, 2024. It is now read-only.

Conversation

@juliette-ruchel
Copy link
Contributor

Solution for issue #154

@juliette-ruchel juliette-ruchel marked this pull request as ready for review February 4, 2021 11:35
@pooyaj
Copy link
Contributor

pooyaj commented Feb 10, 2021

@juliette-ruchel @nd4p90x could you please update the branch. Conflicts after I merged another PR.

…nto issue#154-Catch-PostAsync-Network-exceptions-and-Retry

# Conflicts:
#	Test.NetStandard20/Test.NetStandard20.csproj
@codecov-io
Copy link

codecov-io commented Feb 11, 2021

Codecov Report

Merging #158 (daeb441) into master (a9670f1) will increase coverage by 3.32%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   86.09%   89.41%   +3.32%     
==========================================
  Files          27       27              
  Lines         791      803      +12     
  Branches       75       78       +3     
==========================================
+ Hits          681      718      +37     
+ Misses        109       83      -26     
- Partials        1        2       +1     
Impacted Files Coverage Δ
Analytics/Request/BlockingRequestHandler.cs 83.69% <80.00%> (+9.27%) ⬆️
Analytics/Config.cs 91.20% <0.00%> (+8.79%) ⬆️
Analytics/Request/Backo.cs 88.88% <0.00%> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9670f1...daeb441. Read the comment docs.

@pooyaj pooyaj merged commit 0b377e0 into segmentio:master Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Events lost before reaching the segment servers Catch PostAsync Network exceptions and Retry

4 participants