AST-9: go wrapper update

[jain-raunak]

• After generation, need to make changes for datatype *interface{} to map[string]interface{}
• Change in folder structure as per https://go.dev/blog/v2-go-modules to upgrade the version
• Rest all changes are due to generation only

[shubhamUpadhyayInBlue]

LGTM

[wazazaby]

Shouldn't the module path here be github.com/sendinblue/APIv3-go-library/v3 instead of v3 ?

[jain-raunak]

Shouldn't the module path here be github.com/sendinblue/APIv3-go-library/v3 instead of v3 ?

Thanks @wazazaby for pointing this out as it got missed while changing the folder structure. It should be github.com/sendinblue/APIv3-go-library/lib as per the current structure.

[wazazaby]

Hmm no, the main module's module path should be github.com/sendinblue/APIv3-go-library/v3, and then the /lib comes from the sub package.
When using it, it will look like this as an import statement : import sib github.com/sendinblue/APIv3-go-library/v3/lib

[jain-raunak]

Hmm no, the main module's module path should be github.com/sendinblue/APIv3-go-library/v3, and then the /lib comes from the sub package. When using it, it will look like this as an import statement : import sib github.com/sendinblue/APIv3-go-library/v3/lib

Is there any specific reason for your suggestion of keeping v3 as main folder?
Because here we are not changing the current structure and making a feature release with fixes. So import path would be same as github.com/sendinblue/APIv3-go-library/lib

[wazazaby]

When you're updating a library to a new major version, the module's module path should contain the major version number (you can read more about this here, at the bottom). Having /v3 in the path doesn't mean you have to put your library in a v3 subfolder.

[jain-raunak]

When you're updating a library to a new major version, the module's module path should contain the major version number (you can read more about this here, at the bottom). Having /v3 in the path doesn't mean you have to put your library in a v3 subfolder.

Hi @wazazaby
Point well taken but here it is not a major version release. It would be a feature release with new tag version as 2.1.0(earlier it was 2.0.1) so no change would be required in module path.

[wazazaby]

With a v2.1.0 tag, your module's module path must be github.com/sendinblue/APIv3-go-library/v2 then.
Try doing a go get with the current path in your go.mod (go get github.com/sendinblue/APIv3-go-library/lib@latest or go get github.com/sendinblue/APIv3-go-library/[email protected] once released), it won't work.

[jain-raunak]

With a v2.1.0 tag, your module's module path must be github.com/sendinblue/APIv3-go-library/v2 then. Try doing a go get with the current path in your go.mod (go get github.com/sendinblue/APIv3-go-library/lib@latest or go get github.com/sendinblue/APIv3-go-library/[email protected] once released), it won't work.

Hi @wazazaby

As a result of our review, we have corrected the module path which has to be done in the earlier major release, as per standards we have to update the module path for all major release which was missed in last one.
Much obliged!

[wazazaby]

@jain-raunak amazing 🙏 thank you

[shubhamUpadhyayInBlue]

LGTM