feat: Support signed request to Elasticsearch service #151
Conversation
h-kishi
force-pushed
the
feat/signed-elasticsearch
branch
2 times, most recently
from
fd2f018 to
d63cfbe
Compare
bboure
force-pushed
the
feat/signed-elasticsearch
branch
from
d63cfbe to
5172947
Compare
| signer.addAuthorization(credentials, new Date()); | ||
|
|
||
| return httpRequest; | ||
| } |
There was a problem hiding this comment.
Could we also add the option to load the keys from env vars and/or local credentials file?
There was a problem hiding this comment.
Good point.
I added elasiticsearch.useSignature option and modified to load credentials from config, env vars or local file.
By the way, I'm using the name elasticsearch in the config, would openSearch be more appropriate?
There was a problem hiding this comment.
Great! thanks!
Yes openSearch is probably what we should start calling things now ✅
There was a problem hiding this comment.
Thanks!
I changed the name from elasticsearch to openSearch.
h-kishi
force-pushed
the
feat/signed-elasticsearch
branch
3 times, most recently
from
f32cec4 to
09ec53f
Compare
bboure
force-pushed
the
master
branch
4 times, most recently
from
d829ea4 to
e4a867b
Compare
h-kishi
force-pushed
the
feat/signed-elasticsearch
branch
3 times, most recently
from
5740adc to
7358bac
Compare
|
@bboure |
|
@h-kishi sorry for the delay There is a merge conflict. |
h-kishi
force-pushed
the
feat/signed-elasticsearch
branch
from
7358bac to
af4c567
Compare
|
@bboure Thank you for the reply. |
|
LGTM Thanks for the contrib! |
|
🎉 This PR is included in version 0.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
I added an implementation sending signed HTTP requests to Amazon Elasticsearch(OpenSearch) Service.
It is almost the same as the official sample.
It is compatible with the original behavior.