Merge pull request #194 from horike37/feature/fix_issue_193

fix: handle null values

Author: theburningmonk

lib/deploy/stepFunctions/compileStateMachines.test.js

@@ -711,4 +711,35 @@ describe('#compileStateMachines', () => {
     expect(params).to.haveOwnProperty(functionParam2);
     expect(params[functionParam2]).to.eql({ Ref: 'MyFunction2' });
   });
+
+  it('should allow null values #193', () => {
+    serverless.service.stepFunctions = {
+      stateMachines: {
+        myStateMachine1: {
+          id: 'Test',
+          name: 'test',
+          definition: {
+            StartAt: 'AnyStep',
+            States: {
+              AnyStep: {
+                Type: 'Pass',
+                ResultPath: null,
+                Next: 'Finish',
+              },
+              Finish: {
+                Type: 'Succeed',
+              },
+            },
+          },
+        },
+      },
+    };
+
+    serverlessStepFunctions.compileStateMachines();
+    const stateMachine = serverlessStepFunctions.serverless.service
+      .provider.compiledCloudFormationTemplate.Resources
+      .Test;
+
+    expect(stateMachine.Properties.DefinitionString).to.not.equal(null);
+  });
 });

lib/utils/aws.js

@@ -1,5 +1,7 @@
+const _ = require('lodash');
+
 function isIntrinsic(obj) {
-  return typeof obj === 'object' &&
+  return _.isObjectLike(obj) &&
     Object.keys(obj).some((k) => k.startsWith('Fn::') || k.startsWith('Ref'));
 }