-
Notifications
You must be signed in to change notification settings - Fork 126
Upgrade to new maintance rules #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It was removed (withuot major version bump) with v2.3.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! 🙏 Thanks @medikoo 👍
I just added one comment regarding a core dependency (we might want to double check if the plugin still works).
"chalk": "^2.4.2", | ||
"fs-extra": "^8.1.0", | ||
"googleapis": "^41.0.1", | ||
"googleapis": "^39.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this breaking since it's a downgrade?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. All tests pass.
Also upgrade from v32 to v41 was made without any extra changes to code: https://github.com/serverless/serverless-google-cloudfunctions/pull/176/files
And that was actually breaking (as it dropped Node.js v6 support, CI didn't pick that as its setup was broken - just lint was run, no tests).
So this is an attempt to bring back support for Node.js v6 in v2 scope, which we will drop with v3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense. Thanks for the clarification 👍
Uh oh!
There was an error while loading. Please reload this page.