Skip to content

Commit 6f08b49

Browse files
Fix workspace configuration for publishing and CI
- Made root package private workspace manager - Made workspace package publishable with proper exports - Fixed CI workflow to pack from workspace package only - Updated build to copy lib output to workspace package - Fixed all package paths to be relative to workspace package 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 0182224 commit 6f08b49

File tree

3 files changed

+45
-45
lines changed

3 files changed

+45
-45
lines changed

.github/workflows/lint-js-and-ruby.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -81,12 +81,12 @@ jobs:
8181
- name: Type-check TypeScript
8282
run: yarn run type-check
8383
- name: Pack for attw and publint
84-
run: yarn pack -f react-on-rails.tgz
84+
run: cd packages/react-on-rails && yarn pack -f react-on-rails.tgz
8585
- name: Lint package types
8686
# our package is ESM-only
87-
run: yarn run attw react-on-rails.tgz --profile esm-only
87+
run: yarn run attw packages/react-on-rails/react-on-rails.tgz --profile esm-only
8888
- name: Lint package publishing
89-
run: yarn run publint --strict react-on-rails.tgz
89+
run: yarn run publint --strict packages/react-on-rails/react-on-rails.tgz
9090
# We only download and run Actionlint if there is any difference in GitHub Action workflows
9191
# https://github.com/rhysd/actionlint/blob/main/docs/usage.md#on-github-actions
9292
- name: Check GitHub Action changes

package.json

Lines changed: 2 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -1,49 +1,14 @@
11
{
22
"name": "react-on-rails",
33
"version": "16.1.1",
4-
"description": "react-on-rails JavaScript for react_on_rails Ruby gem",
5-
"main": "node_package/lib/ReactOnRails.full.js",
6-
"type": "module",
7-
"exports": {
8-
".": {
9-
"react-server": "./node_package/lib/pro/ReactOnRailsRSC.js",
10-
"node": "./node_package/lib/ReactOnRails.node.js",
11-
"default": "./node_package/lib/ReactOnRails.full.js"
12-
},
13-
"./client": "./node_package/lib/ReactOnRails.client.js",
14-
"./registerServerComponent/client": "./node_package/lib/pro/registerServerComponent/client.js",
15-
"./registerServerComponent/server": {
16-
"react-server": "./node_package/lib/pro/registerServerComponent/server.rsc.js",
17-
"default": "./node_package/lib/pro/registerServerComponent/server.js"
18-
},
19-
"./wrapServerComponentRenderer/client": "./node_package/lib/pro/wrapServerComponentRenderer/client.js",
20-
"./wrapServerComponentRenderer/server": {
21-
"react-server": "./node_package/lib/pro/wrapServerComponentRenderer/server.rsc.js",
22-
"default": "./node_package/lib/pro/wrapServerComponentRenderer/server.js"
23-
},
24-
"./RSCRoute": "./node_package/lib/pro/RSCRoute.js",
25-
"./RSCProvider": "./node_package/lib/pro/RSCProvider.js",
26-
"./ServerComponentFetchError": "./node_package/lib/pro/ServerComponentFetchError.js"
27-
},
4+
"description": "react-on-rails monorepo workspace manager",
5+
"private": true,
286
"workspaces": [
297
"packages/react-on-rails"
308
],
319
"directories": {
3210
"doc": "docs"
3311
},
34-
"peerDependencies": {
35-
"react": ">= 16",
36-
"react-dom": ">= 16",
37-
"react-on-rails-rsc": "19.0.2"
38-
},
39-
"peerDependenciesMeta": {
40-
"react-on-rails-rsc": {
41-
"optional": true
42-
}
43-
},
44-
"files": [
45-
"node_package/lib"
46-
],
4712
"devDependencies": {
4813
"@arethetypeswrong/cli": "^0.17.4",
4914
"@babel/core": "^7.20.12",

packages/react-on-rails/package.json

Lines changed: 40 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
11
{
22
"name": "react-on-rails",
33
"version": "16.1.1",
4-
"description": "react-on-rails workspace package - not for publishing",
5-
"private": true,
4+
"description": "react-on-rails JavaScript for react_on_rails Ruby gem",
5+
"main": "lib/ReactOnRails.full.js",
6+
"type": "module",
67
"scripts": {
7-
"build": "yarn run clean && yarn run tsc --declaration",
8+
"build": "yarn run clean && yarn run tsc --declaration && cp -r ../../node_package/lib ./lib",
89
"build-watch": "yarn run clean && yarn run tsc --watch",
9-
"clean": "rm -rf ../../node_package/lib",
10+
"clean": "rm -rf ../../node_package/lib ./lib",
1011
"test": "cd ../.. && jest node_package/tests",
1112
"type-check": "yarn run tsc --noEmit --noErrorTruncation"
1213
},
@@ -23,7 +24,41 @@
2324
"Rails"
2425
],
2526
"author": "[email protected]",
26-
"license": "MIT",
27+
"license": "SEE LICENSE IN LICENSE.md",
28+
"exports": {
29+
".": {
30+
"react-server": "./lib/pro/ReactOnRailsRSC.js",
31+
"node": "./lib/ReactOnRails.node.js",
32+
"default": "./lib/ReactOnRails.full.js"
33+
},
34+
"./client": "./lib/ReactOnRails.client.js",
35+
"./registerServerComponent/client": "./lib/pro/registerServerComponent/client.js",
36+
"./registerServerComponent/server": {
37+
"react-server": "./lib/pro/registerServerComponent/server.rsc.js",
38+
"default": "./lib/pro/registerServerComponent/server.js"
39+
},
40+
"./wrapServerComponentRenderer/client": "./lib/pro/wrapServerComponentRenderer/client.js",
41+
"./wrapServerComponentRenderer/server": {
42+
"react-server": "./lib/pro/wrapServerComponentRenderer/server.rsc.js",
43+
"default": "./lib/pro/wrapServerComponentRenderer/server.js"
44+
},
45+
"./RSCRoute": "./lib/pro/RSCRoute.js",
46+
"./RSCProvider": "./lib/pro/RSCProvider.js",
47+
"./ServerComponentFetchError": "./lib/pro/ServerComponentFetchError.js"
48+
},
49+
"peerDependencies": {
50+
"react": ">= 16",
51+
"react-dom": ">= 16",
52+
"react-on-rails-rsc": "19.0.2"
53+
},
54+
"peerDependenciesMeta": {
55+
"react-on-rails-rsc": {
56+
"optional": true
57+
}
58+
},
59+
"files": [
60+
"lib"
61+
],
2762
"bugs": {
2863
"url": "https://github.com/shakacode/react_on_rails/issues"
2964
},

0 commit comments

Comments
 (0)