Skip to content

Commit e09be6f

Browse files
authored
Remove package-lock.json, add instructions for coding agents (#1804)
1 parent 8678270 commit e09be6f

File tree

3 files changed

+5
-11987
lines changed

3 files changed

+5
-11987
lines changed

CLAUDE.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ This file provides guidance to Claude Code (claude.ai/code) when working with co
99
1. **ALWAYS run `bundle exec rubocop` and fix ALL violations**
1010
2. **ALWAYS ensure files end with a newline character**
1111
3. **NEVER push without running full lint check first**
12-
4. **ALWAYS let Prettier handle ALL formatting - never manually format**
12+
4. **ALWAYS let Prettier and RuboCop handle ALL formatting - never manually format**
1313

1414
These requirements are non-negotiable. CI will fail if not followed.
1515

@@ -39,10 +39,11 @@ Git hooks will automatically run linting on **all changed files (staged + unstag
3939
- **Build**: `yarn run build` (compiles TypeScript to JavaScript in node_package/lib)
4040
- **Type checking**: `yarn run type-check`
4141
- **⚠️ MANDATORY BEFORE GIT PUSH**: `bundle exec rubocop` and fix ALL violations + ensure trailing newlines
42+
- Never run `npm` commands, only equivalent Yarn Classic ones
4243

4344
## ⚠️ FORMATTING RULES
4445

45-
**Prettier is the SOLE authority for formatting. NEVER manually format code.**
46+
**Prettier is the SOLE authority for formatting non-Ruby files, and RuboCop for formatting Ruby files. NEVER manually format code.**
4647

4748
### Standard Workflow
4849
1. Make code changes
@@ -120,10 +121,10 @@ This project maintains both a Ruby gem and an NPM package:
120121
## Important Notes
121122

122123
- Use `yalc` for local development when testing with external apps
123-
- The project supports both Webpacker and Shakapacker
124124
- Server-side rendering uses isolated Node.js processes
125125
- React Server Components support available in Pro version
126126
- Generated examples are in `gen-examples/` (ignored by git)
127+
- Only use `yarn` as the JS package manager, never `npm`
127128

128129
## IDE Configuration
129130

CODING_AGENTS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ cd spec/dummy && foreman start # Start dummy app with webpack
3030
- [ ] No trailing whitespace
3131
- [ ] Line length ≤120 characters
3232
- [ ] Security violations properly scoped with disable comments
33+
- [ ] No `package-lock.json` or other non-Yarn lock files (except `Gemfile.lock`)
3334

3435
## Development Patterns for AI Contributors
3536

0 commit comments

Comments
 (0)