Skip to content

Commit 8f1609d

Browse files
sboryanavina
authored andcommitted
SAMZA-1313 : Rename StandaloneJobCoordinator to PassthroughJobCoordinator
Author: Boris Shkolnik <[email protected]> Reviewers: Navina Ramesh <[email protected]> Closes apache#206 from sborya/RenameStandAloneGJobCoordinator
1 parent e5e9705 commit 8f1609d

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

docs/learn/documentation/versioned/jobs/configuration-table.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -420,7 +420,7 @@ <h1>Samza Configuration Reference</h1>
420420
<td class="description">
421421
Class to use for job coordination. Currently available values are:
422422
<dl>
423-
<dt><code>org.apache.samza.standalone.StandaloneJobCoordinatorFactory</code></dt>
423+
<dt><code>org.apache.samza.standalone.PassthroughJobCoordinatorFactory</code></dt>
424424
<dd>Fixed partition mapping. No Zoookeeper. </dd>
425425
<dt><code>org.apache.samza.zk.ZkJobCoordinatorFactory</code></dt>
426426
<dd>Zookeeper-based coordination. </dd>

samza-core/src/main/java/org/apache/samza/standalone/StandaloneJobCoordinator.java renamed to samza-core/src/main/java/org/apache/samza/standalone/PassthroughJobCoordinator.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,13 @@
6262
* </li>
6363
* </ul>
6464
* */
65-
public class StandaloneJobCoordinator implements JobCoordinator {
66-
private static final Logger LOGGER = LoggerFactory.getLogger(StandaloneJobCoordinator.class);
65+
public class PassthroughJobCoordinator implements JobCoordinator {
66+
private static final Logger LOGGER = LoggerFactory.getLogger(PassthroughJobCoordinator.class);
6767
private final String processorId;
6868
private final Config config;
6969
private JobCoordinatorListener coordinatorListener = null;
7070

71-
public StandaloneJobCoordinator(Config config) {
71+
public PassthroughJobCoordinator(Config config) {
7272
this.processorId = createProcessorId(config);
7373
this.config = config;
7474
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222
import org.apache.samza.coordinator.JobCoordinator;
2323
import org.apache.samza.coordinator.JobCoordinatorFactory;
2424

25-
public class StandaloneJobCoordinatorFactory implements JobCoordinatorFactory {
25+
public class PassthroughJobCoordinatorFactory implements JobCoordinatorFactory {
2626
@Override
2727
public JobCoordinator getJobCoordinator(Config config) {
28-
return new StandaloneJobCoordinator(config);
28+
return new PassthroughJobCoordinator(config);
2929
}
3030
}

samza-test/src/test/java/org/apache/samza/test/StandaloneTestUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
import java.util.Map;
2626

2727
public class StandaloneTestUtils {
28-
private static final String STANDALONE_JOB_COORDINATOR_FACTORY = "org.apache.samza.standalone.StandaloneJobCoordinatorFactory";
28+
private static final String PASSTHROUGH_JOB_COORDINATOR_FACTORY = "org.apache.samza.standalone.PassthroughJobCoordinatorFactory";
2929
private static final String STANDALONE_SSP_GROUPER_FACTORY = "org.apache.samza.container.grouper.stream.AllSspToSingleTaskGrouperFactory";
3030
private static final String STANDALONE_TASK_NAME_GROUPER_FACTORY = "org.apache.samza.container.grouper.task.SingleContainerGrouperFactory";
3131
private static final String KAFKA_SYSTEM_FACTORY = "org.apache.samza.system.kafka.KafkaSystemFactory";
@@ -55,7 +55,7 @@ public static Map<String, String> getStandaloneConfigs(final String jobName, fin
5555
{
5656
put(JOB_NAME, jobName);
5757
put(TASK_CLASS, taskClass);
58-
put(JobCoordinatorConfig.JOB_COORDINATOR_FACTORY, STANDALONE_JOB_COORDINATOR_FACTORY);
58+
put(JobCoordinatorConfig.JOB_COORDINATOR_FACTORY, PASSTHROUGH_JOB_COORDINATOR_FACTORY);
5959
put(SSP_GROUPER_FACTORY, STANDALONE_SSP_GROUPER_FACTORY);
6060
put(TASK_NAME_GROUPER_FACTORY, STANDALONE_TASK_NAME_GROUPER_FACTORY);
6161
}

0 commit comments

Comments
 (0)