Skip to content

Commit 9a8099c

Browse files
jmakesJacob Maes
authored andcommitted
Fix a couple sonarcloud issues with samza-1537
Author: Jacob Maes <[email protected]> Reviewers: Jagadish <[email protected]> Closes apache#393 from jmakes/streamappender-sonarcloud
1 parent ef1c962 commit 9a8099c

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

samza-log4j/src/main/java/org/apache/samza/logging/log4j/StreamAppender.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ public void append(LoggingEvent event) {
152152
// Emit a metric which can be monitored to ensure it doesn't happen often.
153153
metrics.logMessagesDropped.inc(messagesDropped);
154154
}
155-
metrics.bufferFillPct.set(Math.round(100 * logQueue.size() / DEFAULT_QUEUE_SIZE));
155+
metrics.bufferFillPct.set(Math.round(100f * logQueue.size() / DEFAULT_QUEUE_SIZE));
156156
}
157157
} catch (Exception e) {
158158
System.err.println("[StreamAppender] Error sending log message:");
@@ -188,7 +188,8 @@ public void close() {
188188
try {
189189
transferThread.join();
190190
} catch (InterruptedException e) {
191-
log.error("Interrupted while waiting for sink thread to finish.", e);
191+
log.error("Interrupted while waiting for transfer thread to finish.", e);
192+
Thread.currentThread().interrupt();
192193
}
193194

194195
flushSystemProducer();

0 commit comments

Comments
 (0)