Skip to content

Commit ff1f53f

Browse files
sebmarkbagesebmarkbage
committed
Warn for useFormState on initial render (facebook#30292)
This was missed in the mount dev dispatcher. It was only in the rerender dispatcher which means that it was only logged during the rerender. Since DevTools can hide logs during rerenders, this hid the warning in StrictMode. DiffTrain build for commit facebook@274c980.
1 parent e99785f commit ff1f53f

File tree

14 files changed

+44
-41
lines changed

14 files changed

+44
-41
lines changed

‎compiled-rn/VERSION_NATIVE_FB‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
19.0.0-native-fb-df783f9ea1-20240708
1+
19.0.0-native-fb-274c980c53-20240708

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-dev.js‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<b79bb3a4890e5e05b0b98d095f5ec6a9>>
10+
* @generated SignedSource<<406a88d1a4fab2a1a30035ac1866b4c5>>
1111
*/
1212

1313
"use strict";
@@ -13722,6 +13722,7 @@ __DEV__ &&
1372213722
HooksDispatcherOnMountInDEV.useFormState = function (action, initialState) {
1372313723
currentHookNameInDev = "useFormState";
1372413724
mountHookTypesDev();
13725+
warnOnUseFormStateInDev();
1372513726
return mountActionState(action, initialState);
1372613727
};
1372713728
HooksDispatcherOnMountInDEV.useActionState = function (
@@ -15079,14 +15080,14 @@ __DEV__ &&
1507915080
scheduleRoot: scheduleRoot,
1508015081
setRefreshHandler: setRefreshHandler,
1508115082
getCurrentFiber: getCurrentFiberForDevTools,
15082-
reconcilerVersion: "19.0.0-native-fb-df783f9ea1-20240708"
15083+
reconcilerVersion: "19.0.0-native-fb-274c980c53-20240708"
1508315084
});
1508415085
})({
1508515086
findFiberByHostInstance: function () {
1508615087
throw Error("TestRenderer does not support findFiberByHostInstance()");
1508715088
},
1508815089
bundleType: 1,
15089-
version: "19.0.0-native-fb-df783f9ea1-20240708",
15090+
version: "19.0.0-native-fb-274c980c53-20240708",
1509015091
rendererPackageName: "react-test-renderer"
1509115092
});
1509215093
exports._Scheduler = Scheduler;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-prod.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<9dcd7685e1640c17fbdf82a52a452035>>
10+
* @generated SignedSource<<e5832359bed54301755c310c71ed4199>>
1111
*/
1212

1313
"use strict";
@@ -9384,7 +9384,7 @@ var devToolsConfig$jscomp$inline_1053 = {
93849384
throw Error("TestRenderer does not support findFiberByHostInstance()");
93859385
},
93869386
bundleType: 0,
9387-
version: "19.0.0-native-fb-df783f9ea1-20240708",
9387+
version: "19.0.0-native-fb-274c980c53-20240708",
93889388
rendererPackageName: "react-test-renderer"
93899389
};
93909390
var internals$jscomp$inline_1240 = {
@@ -9415,7 +9415,7 @@ var internals$jscomp$inline_1240 = {
94159415
scheduleRoot: null,
94169416
setRefreshHandler: null,
94179417
getCurrentFiber: null,
9418-
reconcilerVersion: "19.0.0-native-fb-df783f9ea1-20240708"
9418+
reconcilerVersion: "19.0.0-native-fb-274c980c53-20240708"
94199419
};
94209420
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
94219421
var hook$jscomp$inline_1241 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react-test-renderer/cjs/ReactTestRenderer-profiling.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<661fb6132400bc6cbf49596db0acc720>>
10+
* @generated SignedSource<<919306dbc91ada1359ea3c6b0b32c618>>
1111
*/
1212

1313
"use strict";
@@ -10004,7 +10004,7 @@ var devToolsConfig$jscomp$inline_1136 = {
1000410004
throw Error("TestRenderer does not support findFiberByHostInstance()");
1000510005
},
1000610006
bundleType: 0,
10007-
version: "19.0.0-native-fb-df783f9ea1-20240708",
10007+
version: "19.0.0-native-fb-274c980c53-20240708",
1000810008
rendererPackageName: "react-test-renderer"
1000910009
};
1001010010
(function (internals) {
@@ -10048,7 +10048,7 @@ var devToolsConfig$jscomp$inline_1136 = {
1004810048
scheduleRoot: null,
1004910049
setRefreshHandler: null,
1005010050
getCurrentFiber: null,
10051-
reconcilerVersion: "19.0.0-native-fb-df783f9ea1-20240708"
10051+
reconcilerVersion: "19.0.0-native-fb-274c980c53-20240708"
1005210052
});
1005310053
exports._Scheduler = Scheduler;
1005410054
exports.act = act;

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-dev.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<eee457cdc760bc83f6841edabd786565>>
10+
* @generated SignedSource<<3787381ad3f2eac13a1287257e1acce9>>
1111
*/
1212

1313
"use strict";
@@ -1748,7 +1748,7 @@ __DEV__ &&
17481748
exports.useTransition = function () {
17491749
return resolveDispatcher().useTransition();
17501750
};
1751-
exports.version = "19.0.0-native-fb-df783f9ea1-20240708";
1751+
exports.version = "19.0.0-native-fb-274c980c53-20240708";
17521752
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
17531753
"function" ===
17541754
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-prod.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<7c12730813cc8752d34681669dee99a2>>
10+
* @generated SignedSource<<35b776e96f5f1727760c923395a99766>>
1111
*/
1212

1313
"use strict";
@@ -604,4 +604,4 @@ exports.useSyncExternalStore = function (
604604
exports.useTransition = function () {
605605
return ReactSharedInternals.H.useTransition();
606606
};
607-
exports.version = "19.0.0-native-fb-df783f9ea1-20240708";
607+
exports.version = "19.0.0-native-fb-274c980c53-20240708";

‎compiled-rn/facebook-fbsource/xplat/js/RKJSModules/vendor/react/react/cjs/React-profiling.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<157ac3b6e8ae340940bc85ec2c3806cc>>
10+
* @generated SignedSource<<1b02bac183a08adfa82d1581390cdd01>>
1111
*/
1212

1313
"use strict";
@@ -608,7 +608,7 @@ exports.useSyncExternalStore = function (
608608
exports.useTransition = function () {
609609
return ReactSharedInternals.H.useTransition();
610610
};
611-
exports.version = "19.0.0-native-fb-df783f9ea1-20240708";
611+
exports.version = "19.0.0-native-fb-274c980c53-20240708";
612612
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
613613
"function" ===
614614
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
df783f9ea1b6f95e05f830602da1de5ffb325d30
1+
274c980c535bb34e17f5d97cc22ef4dd296ab413

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-dev.fb.js‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<cb3e48516a63e1d432c10d2a36d40a98>>
10+
* @generated SignedSource<<8f233b6d522b2bcef18aa23caa2b608c>>
1111
*/
1212

1313
"use strict";
@@ -15432,6 +15432,7 @@ __DEV__ &&
1543215432
HooksDispatcherOnMountInDEV.useFormState = function (action, initialState) {
1543315433
currentHookNameInDev = "useFormState";
1543415434
mountHookTypesDev();
15435+
warnOnUseFormStateInDev();
1543515436
return mountActionState(action, initialState);
1543615437
};
1543715438
HooksDispatcherOnMountInDEV.useActionState = function (
@@ -16686,12 +16687,12 @@ __DEV__ &&
1668616687
scheduleRoot: scheduleRoot,
1668716688
setRefreshHandler: setRefreshHandler,
1668816689
getCurrentFiber: getCurrentFiberForDevTools,
16689-
reconcilerVersion: "19.0.0-native-fb-df783f9ea1-20240708"
16690+
reconcilerVersion: "19.0.0-native-fb-274c980c53-20240708"
1669016691
});
1669116692
})({
1669216693
findFiberByHostInstance: getInstanceFromNode,
1669316694
bundleType: 1,
16694-
version: "19.0.0-native-fb-df783f9ea1-20240708",
16695+
version: "19.0.0-native-fb-274c980c53-20240708",
1669516696
rendererPackageName: "react-native-renderer",
1669616697
rendererConfig: {
1669716698
getInspectorDataForInstance: getInspectorDataForInstance,

‎compiled-rn/facebook-fbsource/xplat/js/react-native-github/Libraries/Renderer/implementations/ReactFabric-prod.fb.js‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @noflow
88
* @nolint
99
* @preventMunge
10-
* @generated SignedSource<<bf8cd3f7673a3494d679c3432fe18b20>>
10+
* @generated SignedSource<<6f6cef3e69da66fa484d591f777702cb>>
1111
*/
1212

1313
"use strict";
@@ -10601,7 +10601,7 @@ var roots = new Map(),
1060110601
devToolsConfig$jscomp$inline_1136 = {
1060210602
findFiberByHostInstance: getInstanceFromNode,
1060310603
bundleType: 0,
10604-
version: "19.0.0-native-fb-df783f9ea1-20240708",
10604+
version: "19.0.0-native-fb-274c980c53-20240708",
1060510605
rendererPackageName: "react-native-renderer",
1060610606
rendererConfig: {
1060710607
getInspectorDataForInstance: getInspectorDataForInstance,
@@ -10644,7 +10644,7 @@ var internals$jscomp$inline_1362 = {
1064410644
scheduleRoot: null,
1064510645
setRefreshHandler: null,
1064610646
getCurrentFiber: null,
10647-
reconcilerVersion: "19.0.0-native-fb-df783f9ea1-20240708"
10647+
reconcilerVersion: "19.0.0-native-fb-274c980c53-20240708"
1064810648
};
1064910649
if ("undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__) {
1065010650
var hook$jscomp$inline_1363 = __REACT_DEVTOOLS_GLOBAL_HOOK__;

0 commit comments

Comments
 (0)