Fix an issue when sidzIgnoreNumericStrings is disabled but extension doesn't report numeric strings. Convert all values to strings (#24)

Author: sidz

src/Rules/MagicNumber/AbstractMagicNumberRule.php

@@ -39,7 +39,7 @@ protected function isNumeric(?Expr $expr): bool
      */
     private function ignoreNumber(Expr $scalar): bool
     {
-        return in_array($scalar->value, $this->ignoreMagicNumbers, true);
+        return in_array((string) $scalar->value, array_map('strval', $this->ignoreMagicNumbers), true);
     }
 
     private function isNumericString(?Expr $expr): bool

tests/Rules/MagicNumber/data/assignment-case.php

@@ -9,7 +9,7 @@ function test_func($var4 = 3): void
     $var5 = 0;
     $var5_1 = 1;
     $var5_2 = 2;
-    $var = '0';
+    $var = '3';
 }
 
 $var6 = .1;
@@ -37,3 +37,5 @@ public function calc(): int
 $var = '-5';
 
 $var = new stdClass();
+
+$var = '0';

tests/Rules/MagicNumber/data/match-case.php

@@ -6,7 +6,7 @@
     1 => 'Hi',
     2, 4 => 'There',
     'string in the middle', '5' => 'There',
-    '1', 6 => 'magic number after string',
+    '2', 6 => 'magic number after string',
     default => throw new LogicException(),
     0 => 'Hello',
 };