Skip memory intensive engine test #2809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This still fails CI :( I'm going to just remove the tests. I think that's quite reasonable, I am comfortable that |
paulhauner
changed the title
paulhauner
changed the title
paulhauner
changed the title
Merged
paulhauner
added a commit
that referenced
this pull request
Nov 28, 2021
* Allocate less memory (3GB) in engine tests * Run cargo format * Remove tx too large test Co-authored-by: Michael Sproul <[email protected]>
paulhauner
added a commit
that referenced
this pull request
Nov 28, 2021
* Allocate less memory (3GB) in engine tests * Run cargo format * Remove tx too large test Co-authored-by: Michael Sproul <[email protected]>
paulhauner
added a commit
that referenced
this pull request
Dec 2, 2021
* Allocate less memory (3GB) in engine tests * Run cargo format * Remove tx too large test Co-authored-by: Michael Sproul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
#2768 (comment)
Proposed Changes
Minimise memory usage in the max transaction size test. I couldn't get it any lower than 3GB (see the comments). If it still fails we can delete the test entirely (or question the rationale of having a 1GB transaction limit..).
Additional Info
This follows from #2800.