Skip to content

Delete milagro library #5298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Mar 6, 2024
Merged

Delete milagro library #5298

merged 21 commits into from
Mar 6, 2024

Conversation

@chong-he
Copy link
Member

@chong-he chong-he commented Feb 26, 2024

Proposed Changes

Delete Milagro BLS library from the source code as it is not used anymore

@chong-he chong-he added ready-for-review The code is ready for review code-quality work-in-progress PR is a work-in-progress and removed ready-for-review The code is ready for review labels Feb 26, 2024
@chong-he chong-he added ready-for-review The code is ready for review and removed work-in-progress PR is a work-in-progress labels Mar 1, 2024
jxs
jxs approved these changes Mar 2, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codewise lgtm :) are we not using the milagro feature anymore?

@michaelsproul
Copy link
Member

michaelsproul commented Mar 3, 2024

are we not using the milagro feature anymore?

Yeah the Milagro library is not really recommended for production use, and AFAIK was only being used by 1 user on an ancient CPU (like 2008) that wasn't supported by blst.

@jxs
Copy link
Member

jxs commented Mar 6, 2024

@Mergifyio queue

@mergify
Copy link

mergify bot commented Mar 6, 2024 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The queue conditions cannot be satisfied due to failing checks.

You can take a look at Queue: Embarked in merge queue check runs for more details.

In case of a failure due to a flaky test, you should first retrigger the CI.
Then, re-embark the pull request into the merge queue by posting the comment
@mergifyio refresh on the pull request.

mergify bot added a commit that referenced this pull request Mar 6, 2024
@mergify
Merge of #5298
a65d56c
@mergify mergify bot mentioned this pull request Mar 6, 2024
Closed
5 tasks
@michaelsproul
Copy link
Member

michaelsproul commented Mar 6, 2024

@Mergifyio requeue

@mergify
Copy link

mergify bot commented Mar 6, 2024

requeue

✅ This pull request will be re-embarked automatically

The followup queue command will be automatically executed to re-embark the pull request

@mergify
Copy link

mergify bot commented Mar 6, 2024 •
edited
Loading

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 258eeb5

@michaelsproul michaelsproul added ready-for-merge This PR is ready to merge. and removed ready-for-review The code is ready for review labels Mar 6, 2024
mergify bot added a commit that referenced this pull request Mar 6, 2024
@mergify
Merge of #5298
ed1980d
@mergify mergify bot mentioned this pull request Mar 6, 2024
Closed
5 tasks
@mergify mergify bot merged commit 258eeb5 into sigp:unstable Mar 6, 2024
@michaelsproul michaelsproul added backwards-incompat Backwards-incompatible API change v5.1.0 Q2 2024 labels Mar 6, 2024
@chong-he chong-he deleted the delete-milagro branch July 16, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jxs jxs jxs approved these changes

@michaelsproul michaelsproul Awaiting requested review from michaelsproul

Assignees

No one assigned

Labels

backwards-incompat Backwards-incompatible API change code-quality ready-for-merge This PR is ready to merge. v5.1.0 Q2 2024

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chong-he @michaelsproul @jxs