Skip to content

Code formatting with black and isort #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2022
Merged

Code formatting with black and isort #767

merged 2 commits into from
Apr 6, 2022

Conversation

@kysrpex
Copy link
Contributor

@kysrpex kysrpex commented Apr 6, 2022 •
edited
Loading

Closes: #767.

@kysrpex
Code formatting with black and isort: set formatting rules
8507e6b 
* Add pre-commit configuration file
* Add black, isort and pre-commit to CI
* Ignore E203 in Flake8 (not really PEP8 compliant, see https://black.readthedocs.io/en/stable/the_black_code_style/current_style.html?highlight=E203#slices)
@kysrpex kysrpex added 📖 documentation ℹ️ best practices 💬 discussion The idea is not mature enough to result in an implementation, and needs further discussion. 🔨 simple fix Likely to be solvable in at most a few hours (full-time). labels Apr 6, 2022
@kysrpex kysrpex mentioned this pull request Apr 6, 2022
Closed
@kysrpex kysrpex marked this pull request as ready for review April 6, 2022 15:33
@kysrpex kysrpex force-pushed the feature/isort_black_pre-commit branch from e8be777 to 9c4a7b5 Compare April 6, 2022 15:39
@kysrpex kysrpex merged commit 622a831 into dev Apr 6, 2022
@kysrpex kysrpex deleted the feature/isort_black_pre-commit branch April 6, 2022 15:43
@kysrpex kysrpex linked an issue Apr 6, 2022 that may be closed by this pull request
Add Black code formatting as a pre-commit #719
Closed
@kysrpex kysrpex mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoavnash yoavnash Awaiting requested review from yoavnash yoavnash is a code owner

@pablo-de-andres pablo-de-andres Awaiting requested review from pablo-de-andres pablo-de-andres is a code owner

Assignees

@pablo-de-andres pablo-de-andres

@kysrpex kysrpex

Labels

📖 documentation 🔨 simple fix Likely to be solvable in at most a few hours (full-time). ℹ️ best practices 💬 discussion The idea is not mature enough to result in an implementation, and needs further discussion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Black code formatting as a pre-commit

3 participants

@kysrpex @pablo-de-andres