Accept valueless parameters as true when using a boolean with types option (#410)

Co-authored-by: Sindre Sorhus <[email protected]>

Author: scottenock

base.d.ts

@@ -286,7 +286,8 @@ export type ParseOptions = {
 	});
 	//=> {isAdmin: 'true', flagged: true, isOkay: false}
 	```
-	Note: The `'boolean'` type will also convert `'0'` and `'1'` string values to booleans.
+
+	Note: The `'boolean'` type also converts `'0'` and `'1'` to booleans, and treats valueless keys (e.g. `?flag`) as `true`.
 	*/
 	readonly types?: Record<
 	string,

base.js

@@ -309,6 +309,10 @@ function parseValue(value, options, type) {
 		return type(value);
 	}
 
+	if (type === 'boolean' && value === null) {
+		return true;
+	}
+
 	if (type === 'boolean' && value !== null && (value.toLowerCase() === 'true' || value.toLowerCase() === 'false')) {
 		return value.toLowerCase() === 'true';
 	}

readme.md

@@ -217,7 +217,7 @@ queryString.parse('?isAdmin=true&flagged=true&isOkay=0', {
 //=> {isAdmin: 'true', flagged: true, isOkay: false}
 ```
 
-Note: The `'boolean'` type will also convert `'0'` and `'1'` string values to booleans.
+Note: The `'boolean'` type also converts `'0'` and `'1'` to booleans, and treats valueless keys (e.g. `?flag`) as `true`.
 
 - `'string'`: Parse `phoneNumber` as a string (overriding the `parseNumbers` option):
 

test/parse.js

@@ -592,3 +592,19 @@ test('types option: boolean type accepts 1 and 0 as boolean values', t => {
 		b: false,
 	});
 });
+
+test('types option: boolean type accepts an empty string as true', t => {
+	t.deepEqual(
+		queryString.parse('a&b', {
+			parsebooleans: false,
+			types: {
+				a: 'boolean',
+				b: 'boolean',
+			},
+		}),
+		{
+			a: true,
+			b: true,
+		},
+	);
+});