Skip to content

Conversation

@stevebaum23
Copy link
Contributor

@stevebaum23 stevebaum23 commented Jan 24, 2023

  • When the close function is called it will (p)unsubscribe from the channels it (p)subscribed to in the constructor.
  • Added a test to verify that channels are being unsubscribed from when close is called.

This is implemented in conjunction with socketio/socket.io#4602 to fix #480.

- When the close function is called it will (p)unsubscribe from the channels it (p)subscribed to in the constructor.
- Added a test to verify that channels are being unsubscribed from when close is called.
@stevebaum23
Copy link
Contributor Author

Not sure why the test is failing here. I've tried running the tests locally using docker instances of redis v3 and v4 and they always pass. I pushed a new commit that adds a delay before starting the test. My theory is that not all the subscriptions have completed by the time test starts to run.

@stevebaum23
Copy link
Contributor Author

@darrachequesne Would you mind kicking off the tests again, to see if they pass? I don't think I can kick them off.

@stevebaum23
Copy link
Contributor Author

@darrachequesne Sorry, I had a formatting issue that caused the tests to not run. When you get a chance, can you kick them off again? Thanks!

@stevebaum23
Copy link
Contributor Author

@darrachequesne I sorted the test out. I wasn't running against the latest version of redis. 🤦 These should pass now.

@stevebaum23
Copy link
Contributor Author

@darrachequesne If you get a chance, can you kick off the tests again?

@darrachequesne darrachequesne merged commit fe89f7e into socketio:main Feb 8, 2023
@darrachequesne
Copy link
Member

Released in version 8.1.0. Thanks a lot!

@stevebaum23 stevebaum23 deleted the implement-adapter-close branch February 8, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

High redis latency with large amount of dynamic namespaces

2 participants