-
-
Notifications
You must be signed in to change notification settings - Fork 606
Add custom style for each calendar event #1246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom style for each calendar event #1246
Conversation
|
Hi @patriksvensson, I'm sorry, but I'm new to GitHub contributions.
I apologize if this is not the correct way, or if you have already been notified about these 3 PRs and you will be checking them in the future. I just wanted to make sure to bring them to your attention. |
|
@davide-pi Hello, yes we do not automatically assign reviewers to PRs. We do things as we have time. Right now we’re all on summer vacation so work on this project will be at a minimum. We work on this project in our spare time and we all have jobs and families so there isn’t really an SLA. Someone will get around to reviewing this at some point. I will try to set aside some time next week. |
|
Thanks for explaining. I will wait for a review when someone of you has time. Thanks again. |
|
I haven't seen this pull request and therefore created #1254... :D The benefit of this here is that there's still the option to specify a default highlight color for the whole calendar while mine doesn't allow that (In my case that was ok, as I don't need the option either way). |
|
This one would be really nice and I guess is neither breaking nor difficult to verify that it works... |
|
@patriksvensson Can we get this into the next release, please? (At the moment, I maintain a custom fork of the project to use the feature...) 😅 |
|
Good morning @patriksvensson, can you find some time to check this PR? Thanks in advance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
|
Do we have a guess when the next version will be available? |
|
No, not yet. You can use the preview version until it's been released. |
Description
Implemented the custom highlight style for single calendar event.
Also requested with issue #1234.
Example
As shown below the calendar now support the default highlight style
2023-06-22but also support different style for different events like2023-06-24and2023-06-25in yellow foreground and2023-06-27with red foregroundTo Test
To test this implementation is sufficient to put it into the
Mainmethod of theProgram.csin theSpectre.Console.Analyzer.Sandbox.Please upvote 👍 this pull request if you are interested in it.