Enhance weekly financial reports workflow tests and error handling

- Added a mock for `fetchFinancialAppData` in the test suite to validate its integration with the `weeklyFinancialReportsWorkflow`.
- Implemented a new test case to ensure that errors from `fetchFinancialAppData` are properly propagated.
- Updated the error message for invalid group names to correct a typo in the parameter name.

These changes improve the robustness of the workflow tests and ensure accurate error reporting.

Author: anatolyshipitz

workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.test.ts

@@ -7,42 +7,38 @@ import { weeklyFinancialReportsWorkflow } from './weeklyFinancialReports.workflo
 
 vi.mock('@temporalio/workflow', () => {
   const getTargetUnitsMock = vi.fn();
+  const fetchFinancialAppDataMock = vi.fn();
 
   return {
     proxyActivities: () => ({
       getTargetUnits: getTargetUnitsMock,
+      fetchFinancialAppData: fetchFinancialAppDataMock,
     }),
     __getTargetUnitsMock: () => getTargetUnitsMock,
+    __getFetchFinancialAppDataMock: () => fetchFinancialAppDataMock,
   };
 });
 
 describe('weeklyFinancialReportsWorkflow', () => {
   type WorkflowModuleWithMock = typeof workflowModule & {
     __getTargetUnitsMock: () => ReturnType<typeof vi.fn>;
+    __getFetchFinancialAppDataMock: () => ReturnType<typeof vi.fn>;
   };
   const getTargetUnitsMock = (
     workflowModule as WorkflowModuleWithMock
   ).__getTargetUnitsMock();
+  const fetchFinancialAppDataMock = (
+    workflowModule as WorkflowModuleWithMock
+  ).__getFetchFinancialAppDataMock();
 
   beforeEach(() => {
     getTargetUnitsMock.mockReset();
+    fetchFinancialAppDataMock.mockReset();
   });
 
-  it.each([[GroupNameEnum.SD_REPORT], [GroupNameEnum.ED_REPORT]])(
-    'returns the fileLink from getTargetUnits for group %s',
-    async (groupName: GroupNameEnum) => {
-      getTargetUnitsMock.mockResolvedValueOnce({
-        fileLink: `${groupName}-mocked-link.json`,
-      });
-      const result = await weeklyFinancialReportsWorkflow(groupName);
-
-      expect(result).toBe(`${groupName}-mocked-link.json`);
-    },
-  );
-
   it('throws AppError for invalid group name', async () => {
     const allowedValues = Object.values(GroupNameEnum).join('", "');
-    const expectedMessage = `Invalid groupName paramter: INVALID_GROUP. Allowed values: "${allowedValues}"`;
+    const expectedMessage = `Invalid groupName parameter: INVALID_GROUP. Allowed values: "${allowedValues}"`;
 
     await expect(
       weeklyFinancialReportsWorkflow(
@@ -62,4 +58,26 @@ describe('weeklyFinancialReportsWorkflow', () => {
       weeklyFinancialReportsWorkflow(GroupNameEnum.SD_REPORT),
     ).rejects.toThrow('activity error');
   });
+
+  it('propagates error from fetchFinancialAppData', async () => {
+    getTargetUnitsMock.mockResolvedValueOnce({ fileLink: 'file.json' });
+    fetchFinancialAppDataMock.mockRejectedValueOnce(new Error('fetch error'));
+    await expect(
+      weeklyFinancialReportsWorkflow(GroupNameEnum.SD_REPORT),
+    ).rejects.toThrow('fetch error');
+  });
+
+  it('returns fileLink on success', async () => {
+    getTargetUnitsMock.mockResolvedValueOnce({ fileLink: 'file.json' });
+    fetchFinancialAppDataMock.mockResolvedValueOnce({
+      fileLink: 'result.json',
+    });
+    const result = await weeklyFinancialReportsWorkflow(
+      GroupNameEnum.SD_REPORT,
+    );
+
+    expect(result).toBe('result.json');
+    expect(getTargetUnitsMock).toHaveBeenCalledWith(GroupNameEnum.SD_REPORT);
+    expect(fetchFinancialAppDataMock).toHaveBeenCalledWith('file.json');
+  });
 });

workers/main/src/workflows/weeklyFinancialReports/weeklyFinancialReports.workflow.ts

@@ -16,7 +16,7 @@ export async function weeklyFinancialReportsWorkflow(
 ): Promise<string> {
   if (!(Object.values(GroupNameEnum) as GroupName[]).includes(groupName)) {
     throw new AppError(
-      `Invalid groupName paramter: ${groupName}. Allowed values: "${Object.values(GroupNameEnum).join('", "')}"`,
+      `Invalid groupName parameter: ${groupName}. Allowed values: "${Object.values(GroupNameEnum).join('", "')}"`,
       'weeklyFinancialReportsWorkflow',
     );
   }