GH-2184 KafkaBackOffException logged as ERROR

tomazfernandes · tomazfernandes · commit b0c7fa83419a · 2022-03-23T18:59:52.000-03:00
Fixes #2184
diff --git a/spring-kafka/src/main/java/org/springframework/kafka/listener/FailedRecordProcessor.java b/spring-kafka/src/main/java/org/springframework/kafka/listener/FailedRecordProcessor.java
@@ -159,9 +159,9 @@ protected RecoveryStrategy getRecoveryStrategy(List<ConsumerRecord<?, ?>> record
 					else {
 						this.logger.error(ex, () -> "Recovery of record ("
 								+ KafkaUtils.format(records.get(0)) + ") failed");
-						this.failureTracker.getRetryListeners().forEach(rl ->
-								rl.recoveryFailed(records.get(0), thrownException, ex));
 					}
+					this.failureTracker.getRetryListeners().forEach(rl ->
+							rl.recoveryFailed(records.get(0), thrownException, ex));
 				}
 				return (rec, excep, cont, consumer) -> NEVER_SKIP_PREDICATE.test(rec, excep);
 			}

Original file line number	Diff line number	Diff line change
`@@ -159,9 +159,9 @@ protected RecoveryStrategy getRecoveryStrategy(List<ConsumerRecord<?, ?>> record`
`159`	`159`	`else {`
`160`	`160`	`this.logger.error(ex, () -> "Recovery of record ("`
`161`	`161`	`+ KafkaUtils.format(records.get(0)) + ") failed");`
`162`		`- this.failureTracker.getRetryListeners().forEach(rl ->`
`163`		`- rl.recoveryFailed(records.get(0), thrownException, ex));`
`164`	`162`	`}`
	`163`	`+ this.failureTracker.getRetryListeners().forEach(rl ->`
	`164`	`+ rl.recoveryFailed(records.get(0), thrownException, ex));`
`165`	`165`	`}`
`166`	`166`	`return (rec, excep, cont, consumer) -> NEVER_SKIP_PREDICATE.test(rec, excep);`
`167`	`167`	`}`