Skip to content

Commit f95166d

Browse files
committed
clarify no-longer-crashing test case
1 parent 6929ec2 commit f95166d

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

Workflow/Tests/ConcurrencyTests.swift

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -160,7 +160,10 @@ final class ConcurrencyTests: XCTestCase {
160160
let secondScreen = host.rendering.value
161161
XCTAssertEqual(1, secondScreen.count)
162162

163-
// Calling `update` uses the original sink.
163+
// Calling `update` uses the original sink. Historically this would be expected
164+
// to trigger a fatal error, but as of https://github.com/square/workflow-swift/pull/189
165+
// the internal event handling infrastructure is expected to have been
166+
// torn down by this point, so this should just no-op.
164167
initialScreen.update()
165168

166169
// If the sink *was* still valid, this would be correct. However, it should just fail and be `1` still.

0 commit comments

Comments
 (0)