Skip to content

Commit edba15e

Browse files
committed
Fix test with delayed jobs
The time was being counted after the message was sent. This caused errors from time to time as it could take some milliseconds less than the delay value (ex. 994ms). Signed-off-by: Javi Fontan <[email protected]>
1 parent eb1b2b0 commit edba15e

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

test/suite.go

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -321,6 +321,8 @@ func (s *QueueSuite) newQueueWithJobs(n int) queue.Queue {
321321
func (s *QueueSuite) TestDelayed() {
322322
assert := assert.New(s.T())
323323

324+
delay := 1 * time.Second
325+
324326
qName := NewName()
325327
q, err := s.Broker.Queue(qName)
326328
assert.NoError(err)
@@ -330,14 +332,15 @@ func (s *QueueSuite) TestDelayed() {
330332
assert.NoError(err)
331333
err = j.Encode("hello")
332334
assert.NoError(err)
333-
err = q.PublishDelayed(j, 1*time.Second)
335+
336+
start := time.Now()
337+
err = q.PublishDelayed(j, delay)
334338
assert.NoError(err)
335339

336340
advertisedWindow := 1
337341
iter, err := q.Consume(advertisedWindow)
338342
assert.NoError(err)
339343

340-
start := time.Now()
341344
var since time.Duration
342345
for {
343346
j, err := iter.Next()
@@ -355,7 +358,7 @@ func (s *QueueSuite) TestDelayed() {
355358
break
356359
}
357360

358-
assert.True(since >= 1*time.Second)
361+
assert.True(since >= delay)
359362
}
360363

361364
func (s *QueueSuite) TestTransaction_Error() {

0 commit comments

Comments
 (0)