Use ExceptionDispatchInfo to retain call stack in AsyncResult.EndInvoke() (#1470)

scott-xu · web-flow · commit a067e2852a59 · 2024-08-12T09:30:24.000+02:00
diff --git a/src/Renci.SshNet/Common/AsyncResult.cs b/src/Renci.SshNet/Common/AsyncResult.cs
@@ -1,4 +1,5 @@
 ﻿using System;
+using System.Runtime.ExceptionServices;
 using System.Threading;
 
 namespace Renci.SshNet.Common
@@ -85,7 +86,7 @@ internal void EndInvoke()
             // Operation is done: if an exception occurred, throw it
             if (_exception != null)
             {
-                throw _exception;
+                ExceptionDispatchInfo.Capture(_exception).Throw();
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`using System;`
	`2`	`+using System.Runtime.ExceptionServices;`
`2`	`3`	`using System.Threading;`
`3`	`4`
`4`	`5`	`namespace Renci.SshNet.Common`
`@@ -85,7 +86,7 @@ internal void EndInvoke()`
`85`	`86`	`// Operation is done: if an exception occurred, throw it`
`86`	`87`	`if (_exception != null)`
`87`	`88`	`{`
`88`		`- throw _exception;`
	`89`	`+ ExceptionDispatchInfo.Capture(_exception).Throw();`
`89`	`90`	`}`
`90`	`91`	`}`
`91`	`92`